From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXjOf-0006N8-6i for qemu-devel@nongnu.org; Wed, 19 Jul 2017 03:27:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXjOe-0000fT-E1 for qemu-devel@nongnu.org; Wed, 19 Jul 2017 03:27:49 -0400 Received: from [59.151.112.132] (port=35078 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXjOe-0000em-1S for qemu-devel@nongnu.org; Wed, 19 Jul 2017 03:27:48 -0400 From: Zhang Chen Date: Wed, 19 Jul 2017 15:29:59 +0800 Message-ID: <1500449399-19107-5-git-send-email-zhangchen.fnst@cn.fujitsu.com> In-Reply-To: <1500449399-19107-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> References: <1500449399-19107-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH V3 4/4] net/colo-compare.c: Fix comments and scheme List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu devel , Jason Wang Cc: Zhang Chen , zhanghailiang , Li Zhijian , "Dr . David Alan Gilbert" Signed-off-by: Zhang Chen --- net/colo-compare.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 58c3250..d10abb2 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -47,7 +47,7 @@ + CompareState ++ | | +---------------+ +---------------+ +---------------+ - |conn list +--->conn +--------->conn | + |conn list +--->conn +--------->conn |---> ....... +---------------+ +---------------+ +---------------+ | | | | | | +---------------+ +---v----+ +---v----+ +---v----+ +---v----+ @@ -81,14 +81,14 @@ typedef struct CompareState { /* Record the last checkpoint time */ int64_t checkpoint_time_ms; - /* connection list: the connections belonged to this NIC could be found - * in this list. - * element type: Connection + /* + * Record the connection that through the NIC + * Element type: Connection */ GQueue conn_list; - /* hashtable to save connection */ + /* Record the connection without repetition */ GHashTable *connection_track_table; - /* compare thread, a thread for each NIC */ + /* This thread just do packet compare job */ QemuThread thread; GMainContext *worker_context; @@ -450,8 +450,11 @@ static int colo_old_packet_check_one_conn(Connection *conn, (GCompareFunc)colo_old_packet_check_one); if (result) { - /* do checkpoint will flush old packet */ - /* TODO: colo_notify_checkpoint();*/ + /* Do checkpoint will flush old packet */ + /* + * TODO: Notify colo frame to do checkpoint. + * colo_compare_inconsistent_notify(); + */ return 0; } -- 2.7.4