From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: eblake@redhat.com, berrange@redhat.com, kwolf@redhat.com,
mreitz@redhat.com, qemu-block@nongnu.org, quintela@redhat.com,
dgilbert@redhat.com
Subject: [Qemu-devel] [PATCH v2 04/10] tests/test-qobject-input-visitor: Drop redundant test
Date: Thu, 20 Jul 2017 09:53:35 +0200 [thread overview]
Message-ID: <1500537221-20556-5-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1500537221-20556-1-git-send-email-armbru@redhat.com>
test_visitor_in_alternate() tests UserDefAlternate with inadmissible
input. test_visitor_in_fail_alternate() does basically the same.
Drop the former, keep the latter.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
---
tests/test-qobject-input-visitor.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tests/test-qobject-input-visitor.c b/tests/test-qobject-input-visitor.c
index f451844..bcf0261 100644
--- a/tests/test-qobject-input-visitor.c
+++ b/tests/test-qobject-input-visitor.c
@@ -567,7 +567,6 @@ static void test_visitor_in_alternate(TestInputVisitorData *data,
const void *unused)
{
Visitor *v;
- Error *err = NULL;
UserDefAlternate *tmp;
WrapAlternate *wrap;
@@ -599,11 +598,6 @@ static void test_visitor_in_alternate(TestInputVisitorData *data,
g_assert_cmpint(tmp->u.udfu.u.value1.has_a_b, ==, false);
qapi_free_UserDefAlternate(tmp);
- v = visitor_input_test_init(data, "false");
- visit_type_UserDefAlternate(v, NULL, &tmp, &err);
- error_free_or_abort(&err);
- qapi_free_UserDefAlternate(tmp);
-
v = visitor_input_test_init(data, "{ 'alt': 42 }");
visit_type_WrapAlternate(v, NULL, &wrap, &error_abort);
g_assert_cmpint(wrap->alt->type, ==, QTYPE_QNUM);
--
2.7.5
next prev parent reply other threads:[~2017-07-20 7:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 7:53 [Qemu-devel] [PATCH v2 00/10] Correct two minor QMP interface design flaws Markus Armbruster
2017-07-20 7:53 ` [Qemu-devel] [PATCH v2 01/10] qapi: Separate type QNull from QObject Markus Armbruster
2017-07-20 7:53 ` [Qemu-devel] [PATCH v2 02/10] qapi: Use QNull for a more regular visit_type_null() Markus Armbruster
2017-07-20 7:53 ` [Qemu-devel] [PATCH v2 03/10] qapi: Introduce a first class 'null' type Markus Armbruster
2017-07-20 7:53 ` Markus Armbruster [this message]
2017-07-20 7:53 ` [Qemu-devel] [PATCH v2 05/10] block: Use JSON null instead of "" to disable backing file Markus Armbruster
2017-07-20 7:53 ` [Qemu-devel] [PATCH v2 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter() Markus Armbruster
2017-07-20 7:53 ` [Qemu-devel] [PATCH v2 07/10] migration: Clean up around tls_creds, tls_hostname Markus Armbruster
2017-07-20 7:53 ` [Qemu-devel] [PATCH v2 08/10] migration: Add TODO comments on duplication of QAPI_CLONE() Markus Armbruster
2017-07-20 7:53 ` [Qemu-devel] [PATCH v2 09/10] migration: Unshare MigrationParameters struct for now Markus Armbruster
2017-07-20 7:53 ` [Qemu-devel] [PATCH v2 10/10] migration: Use JSON null instead of "" to reset parameter to default Markus Armbruster
2017-08-16 21:34 ` [Qemu-devel] [Qemu-block] [PATCH v2 00/10] Correct two minor QMP interface design flaws John Snow
2017-08-16 21:41 ` Eric Blake
2017-08-16 21:42 ` John Snow
2017-08-17 4:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500537221-20556-5-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).