qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	Pankaj Gupta <pagupta@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	kvm-devel <kvm@vger.kernel.org>,
	Qemu Developers <qemu-devel@nongnu.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
	ross zwisler <ross.zwisler@linux.intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Nitesh Narayan Lal <nilal@redhat.com>,
	xiaoguangrong eric <xiaoguangrong.eric@gmail.com>,
	Haozhong Zhang <haozhong.zhang@intel.com>,
	"Zwisler, Ross" <ross.zwisler@intel.com>, Jan Kara <jack@suse.cz>
Subject: Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion
Date: Sun, 23 Jul 2017 14:10:28 -0400	[thread overview]
Message-ID: <1500833428.4073.36.camel@redhat.com> (raw)
In-Reply-To: <CAPcyv4h5O4D2kp6SJhWiz4V=dOLDa_Q3pk2B=u-x7hKKQqdXsQ@mail.gmail.com>

On Sun, 2017-07-23 at 09:01 -0700, Dan Williams wrote:
> [ adding Ross and Jan ]
> 
> On Sun, Jul 23, 2017 at 7:04 AM, Rik van Riel <riel@redhat.com>
> wrote:
> > 
> > The goal is to increase density of guests, by moving page
> > cache into the host (where it can be easily reclaimed).
> > 
> > If we assume the guests will be backed by relatively fast
> > SSDs, a "whole device flush" from filesystem journaling
> > code (issued where the filesystem issues a barrier or
> > disk cache flush today) may be just what we need to make
> > that work.
> 
> Ok, apologies, I indeed had some pieces of the proposal confused.
> 
> However, it still seems like the storage interface is not capable of
> expressing what is needed, because the operation that is needed is a
> range flush. In the guest you want the DAX page dirty tracking to
> communicate range flush information to the host, but there's no
> readily available block i/o semantic that software running on top of
> the fake pmem device can use to communicate with the host. Instead
> you
> want to intercept the dax_flush() operation and turn it into a queued
> request on the host.
> 
> In 4.13 we have turned this dax_flush() operation into an explicit
> driver call. That seems a better interface to modify than trying to
> map block-storage flush-cache / force-unit-access commands to this
> host request.
> 
> The additional piece you would need to consider is whether to track
> all writes in addition to mmap writes in the guest as DAX-page-cache
> dirtying events, or arrange for every dax_copy_from_iter()
> operation()
> to also queue a sync on the host, but that essentially turns the host
> page cache into a pseudo write-through mode.

I suspect initially it will be fine to not offer DAX
semantics to applications using these "fake DAX" devices
from a virtual machine, because the DAX APIs are designed
for a much higher performance device than these fake DAX
setups could ever give.

Having userspace call fsync/msync like done normally, and
having those coarser calls be turned into somewhat efficient
backend flushes would be perfectly acceptable.

The big question is, what should that kind of interface look
like?

  reply	other threads:[~2017-07-23 18:10 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1455443283.33337333.1500618150787.JavaMail.zimbra@redhat.com>
2017-07-21  6:56 ` [Qemu-devel] KVM "fake DAX" flushing interface - discussion Pankaj Gupta
2017-07-21  9:51   ` Haozhong Zhang
2017-07-21 10:21     ` Pankaj Gupta
2017-07-21 12:12   ` Stefan Hajnoczi
2017-07-21 13:29     ` Pankaj Gupta
2017-07-21 14:00       ` Rik van Riel
2017-07-21 15:58       ` Stefan Hajnoczi
2017-07-22 19:34         ` Dan Williams
2017-07-23 14:04           ` Rik van Riel
2017-07-23 16:01             ` Dan Williams
2017-07-23 18:10               ` Rik van Riel [this message]
2017-07-23 20:10                 ` Dan Williams
2017-07-24 10:23                   ` Jan Kara
2017-07-24 12:06                     ` Pankaj Gupta
2017-07-24 12:37                       ` Jan Kara
2017-07-24 15:10                         ` Dan Williams
2017-07-24 15:48                           ` Jan Kara
2017-07-24 16:19                             ` Dan Williams
2017-07-25 14:27                         ` Pankaj Gupta
2017-07-25 14:46                           ` Dan Williams
2017-07-25 20:59                             ` Rik van Riel
2017-07-26 13:47                               ` Pankaj Gupta
2017-07-26 21:27                                 ` Rik van Riel
2017-07-26 21:40                                   ` Dan Williams
2017-07-26 23:46                                     ` Rik van Riel
2017-07-27  0:54                                       ` Dan Williams
2017-10-31  7:13                                         ` Xiao Guangrong
2017-10-31 14:20                                           ` Dan Williams
2017-11-01  3:43                                             ` Xiao Guangrong
2017-11-01  4:25                                               ` Dan Williams
2017-11-01  6:46                                                 ` Xiao Guangrong
2017-11-01 15:20                                                   ` Dan Williams
2017-11-02  8:50                                                     ` Xiao Guangrong
2017-11-02 16:30                                                       ` Dan Williams
2017-11-03  6:21                                                         ` Xiao Guangrong
2017-11-21 18:19                                                           ` Rik van Riel
2017-11-21 18:26                                                             ` Dan Williams
2017-11-21 18:35                                                               ` Rik van Riel
2017-11-23  4:05                                                             ` Xiao Guangrong
2017-11-23 16:14                                                               ` Dan Williams
2017-11-23 16:28                                                                 ` Paolo Bonzini
2017-11-24 12:40                                                                   ` Pankaj Gupta
2017-11-24 12:44                                                                     ` Paolo Bonzini
2017-11-24 13:02                                                                       ` Pankaj Gupta
2017-11-24 13:20                                                                         ` Paolo Bonzini
2017-11-28 18:03                                                                     ` Dan Williams
2018-01-13  6:23                                                                       ` Pankaj Gupta
2018-01-17 16:17                                                                         ` Dan Williams
2018-01-17 17:31                                                                           ` Pankaj Gupta
2018-01-18 16:53                                                                     ` David Hildenbrand
2018-01-18 17:38                                                                       ` Dan Williams
2018-01-18 17:48                                                                         ` David Hildenbrand
2018-01-18 18:45                                                                           ` Dan Williams
2018-01-18 18:54                                                                           ` Pankaj Gupta
2018-01-18 18:59                                                                             ` Dan Williams
2018-01-18 19:36                                                                               ` Pankaj Gupta
2018-01-18 19:48                                                                                 ` Dan Williams
2018-01-18 19:51                                                                               ` David Hildenbrand
2018-01-18 20:11                                                                                 ` Dan Williams
2017-11-06  7:57                                                         ` Pankaj Gupta
2017-11-06 16:57                                                           ` Dan Williams
2017-11-07 11:21                                                             ` Pankaj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500833428.4073.36.camel@redhat.com \
    --to=riel@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=haozhong.zhang@intel.com \
    --cc=jack@suse.cz \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=nilal@redhat.com \
    --cc=pagupta@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ross.zwisler@intel.com \
    --cc=ross.zwisler@linux.intel.com \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).