[Qemu-devel] [PULL 0/1] Error reporting patches for 2017-07-24

[Qemu-devel] [PULL 0/1] Error reporting patches for 2017-07-24

[Markus Armbruster]

The following changes since commit df95f1a298a3e16c80293343143dcedbe7978f6c:

  Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170721-tag' into staging (2017-07-24 10:01:15 +0100)

are available in the git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-error-2017-07-24

for you to fetch changes up to 70f17a15ca0fe47eeae1ac83086130e6e7ba57c8:

  error: Revert unwanted change of warning messages (2017-07-24 14:16:29 +0200)

----------------------------------------------------------------
Error reporting patches for 2017-07-24

----------------------------------------------------------------
Markus Armbruster (1):
      error: Revert unwanted change of warning messages

 util/qemu-error.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

-- 
2.7.5

[Qemu-devel] [PULL 1/1] error: Revert unwanted change of warning messages

[Markus Armbruster]

Commit 97f4030 changed warning messages from

    timestamp-if-enabled progname ":" location "warning: " message

to

    "warning: " timestamp-if-enabled progname ":" location message

This regressed qemu-iotests 051.  Put "warning: " right back where it
was, along with "info: ".

Reported-by: Kevin Wolf <kwolf@redhat.com>
Cc: Alistair Francis <alistair.francis@xilinx.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1500449614-16811-1-git-send-email-armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
 util/qemu-error.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/util/qemu-error.c b/util/qemu-error.c
index c557c6a..a25d3b9 100644
--- a/util/qemu-error.c
+++ b/util/qemu-error.c
@@ -201,17 +201,6 @@ static void vreport(report_type type, const char *fmt, va_list ap)
     GTimeVal tv;
     gchar *timestr;
 
-    switch (type) {
-    case REPORT_TYPE_ERROR:
-        break;
-    case REPORT_TYPE_WARNING:
-        error_printf("warning: ");
-        break;
-    case REPORT_TYPE_INFO:
-        error_printf("info: ");
-        break;
-    }
-
     if (enable_timestamp_msg && !cur_mon) {
         g_get_current_time(&tv);
         timestr = g_time_val_to_iso8601(&tv);
@@ -220,6 +209,18 @@ static void vreport(report_type type, const char *fmt, va_list ap)
     }
 
     print_loc();
+
+    switch (type) {
+    case REPORT_TYPE_ERROR:
+        break;
+    case REPORT_TYPE_WARNING:
+        error_printf("warning: ");
+        break;
+    case REPORT_TYPE_INFO:
+        error_printf("info: ");
+        break;
+    }
+
     error_vprintf(fmt, ap);
     error_printf("\n");
 }
-- 
2.7.5

Re: [Qemu-devel] [PULL 0/1] Error reporting patches for 2017-07-24

[Peter Maydell]

On 24 July 2017 at 13:22, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit df95f1a298a3e16c80293343143dcedbe7978f6c:
>
>   Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170721-tag' into staging (2017-07-24 10:01:15 +0100)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-error-2017-07-24
>
> for you to fetch changes up to 70f17a15ca0fe47eeae1ac83086130e6e7ba57c8:
>
>   error: Revert unwanted change of warning messages (2017-07-24 14:16:29 +0200)
>
> ----------------------------------------------------------------
> Error reporting patches for 2017-07-24
>
> ----------------------------------------------------------------
> Markus Armbruster (1):
>       error: Revert unwanted change of warning messages
>
>  util/qemu-error.c | 23 ++++++++++++-----------
>  1 file changed, 12 insertions(+), 11 deletions(-)

Applied, thanks.

-- PMM