From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZcjn-0001Ve-EH for qemu-devel@nongnu.org; Mon, 24 Jul 2017 08:45:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZcjj-0000Vc-Id for qemu-devel@nongnu.org; Mon, 24 Jul 2017 08:45:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26704) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dZcjj-0000UF-CQ for qemu-devel@nongnu.org; Mon, 24 Jul 2017 08:45:23 -0400 Message-ID: <1500900321.15837.9.camel@redhat.com> From: Gerd Hoffmann Date: Mon, 24 Jul 2017 14:45:21 +0200 In-Reply-To: <20170721110636.19412e6c@nial.brq.redhat.com> References: <3E24AFDE-D25A-416B-A600-3C2221C3A9F1@gmail.com> <20170721110636.19412e6c@nial.brq.redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , Phil Dennis-Jordan Cc: Phil Dennis-Jordan , ehabkost@redhat.com, "qemu-devel@nongnu.org qemu-devel" , Programmingkid , Paolo Bonzini , Richard Henderson Hi, > > 2. Select FADT version with an option. This one is definitely safe, > > but adds yet another option. >=20 > the 3rd simpler option is: > =C2=A0 force rev1 on old machine types (2.9 and older), > =C2=A0 using machine compat machinery and use rev3 on newer machines How about keeping rev1 for pc machine type and use rev3 on q35 only? Old guests which might fall over new acpi stuff usually work better with "pc" anyway ... cheers, Gerd