qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Fritsch <sf@sfritsch.de>
Subject: [Qemu-devel] [PATCH] tests/hmp: Fix typo in the 'chardev-send-break' test
Date: Thu, 27 Jul 2017 11:51:37 +0200	[thread overview]
Message-ID: <1501149097-19071-1-git-send-email-thuth@redhat.com> (raw)

testchardev2 is not a valid chardev id here. Use testchardev1
instead which has been created with chardev-add right before
the 'chardev-send-break' line.
And while we're at it, add the test-hmp.c file to the MAINTAINERS
file, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS      | 1 +
 tests/test-hmp.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5ea273f..ce2341a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1346,6 +1346,7 @@ F: monitor.c
 F: hmp.[ch]
 F: hmp-commands*.hx
 F: include/monitor/hmp-target.h
+F: tests/test-hmp.c
 
 Network device backends
 M: Jason Wang <jasowang@redhat.com>
diff --git a/tests/test-hmp.c b/tests/test-hmp.c
index d77b3c8..729c033 100644
--- a/tests/test-hmp.c
+++ b/tests/test-hmp.c
@@ -22,7 +22,7 @@ static int verbose;
 static const char *hmp_cmds[] = {
     "boot_set ndc",
     "chardev-add null,id=testchardev1",
-    "chardev-send-break testchardev2",
+    "chardev-send-break testchardev1",
     "chardev-change testchardev1 ringbuf",
     "chardev-remove testchardev1",
     "commit all",
-- 
1.8.3.1

             reply	other threads:[~2017-07-27  9:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27  9:51 Thomas Huth [this message]
2017-07-27  9:55 ` [Qemu-devel] [PATCH] tests/hmp: Fix typo in the 'chardev-send-break' test Dr. David Alan Gilbert
2017-08-02 15:35   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501149097-19071-1-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sf@sfritsch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).