From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Subject: [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI
Date: Fri, 28 Jul 2017 15:45:50 +0200 [thread overview]
Message-ID: <1501249552-788-2-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1501249552-788-1-git-send-email-armbru@redhat.com>
ReplayMode is defined in the QAPI schema, but not used there. Of the
stuff QAPI generates for it only the typedef is actually used. Use of
QAPI is pointless and only complicates things, so don't.
Cc: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
include/sysemu/replay.h | 6 ++++++
qapi-schema.json | 18 ------------------
2 files changed, 6 insertions(+), 18 deletions(-)
diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h
index fa14d0e..621bc61 100644
--- a/include/sysemu/replay.h
+++ b/include/sysemu/replay.h
@@ -42,6 +42,12 @@ typedef enum ReplayCheckpoint ReplayCheckpoint;
typedef struct ReplayNetState ReplayNetState;
+typedef enum {
+ REPLAY_MODE_NONE, /* replay / record disabled */
+ REPLAY_MODE_RECORD, /* recording to replay log */
+ REPLAY_MODE_PLAY, /* replaying log */
+} ReplayMode;
+
extern ReplayMode replay_mode;
/* Name of the initial VM snapshot */
diff --git a/qapi-schema.json b/qapi-schema.json
index 9c6c3e1..9b6f6cb 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -6258,24 +6258,6 @@
{ 'include': 'qapi/rocker.json' }
##
-# @ReplayMode:
-#
-# Mode of the replay subsystem.
-#
-# @none: normal execution mode. Replay or record are not enabled.
-#
-# @record: record mode. All non-deterministic data is written into the
-# replay log.
-#
-# @play: replay mode. Non-deterministic data required for system execution
-# is read from the log.
-#
-# Since: 2.5
-##
-{ 'enum': 'ReplayMode',
- 'data': [ 'none', 'record', 'play' ] }
-
-##
# @xen-load-devices-state:
#
# Load the state of all devices from file. The RAM and the block devices
--
2.7.5
next prev parent reply other threads:[~2017-07-28 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 13:45 [Qemu-devel] [PATCH 0/3] Don't QAPI without need Markus Armbruster
2017-07-28 13:45 ` Markus Armbruster [this message]
2017-07-31 6:59 ` [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI Pavel Dovgalyuk
2017-07-31 13:13 ` Markus Armbruster
2017-07-31 13:30 ` Pavel Dovgalyuk
2017-07-28 13:45 ` [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode " Markus Armbruster
2017-07-28 17:17 ` Dr. David Alan Gilbert
2017-07-28 18:07 ` Eric Blake
2017-07-31 9:02 ` Markus Armbruster
2017-07-29 6:49 ` Hailiang Zhang
2017-07-28 13:45 ` [Qemu-devel] [PATCH 3/3] block: Remove unused BlockDeviceMapEntry Markus Armbruster
2017-07-28 18:10 ` Eric Blake
2017-12-15 13:13 ` Max Reitz
2017-07-28 18:10 ` [Qemu-devel] [PATCH 0/3] Don't QAPI without need Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501249552-788-2-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).