qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.10 2/5] tests: acpi: init table descriptor in test_dst_table()
Date: Mon, 31 Jul 2017 17:40:49 +0200	[thread overview]
Message-ID: <1501515652-33372-3-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1501515652-33372-1-git-send-email-imammedo@redhat.com>

remove code duplication and make sure that table descriptor
passed in for initialization is in expected state.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 tests/bios-tables-test.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index b72fa80..adbcc55 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -210,6 +210,7 @@ static void test_dst_table(AcpiSdtTable *sdt_table, uint32_t addr)
 {
     uint8_t checksum;
 
+    memset(sdt_table, 0, sizeof(*sdt_table));
     ACPI_READ_TABLE_HEADER(&sdt_table->header, addr);
 
     sdt_table->aml_len = sdt_table->header.length - sizeof(AcpiTableHeader);
@@ -228,8 +229,6 @@ static void test_acpi_dsdt_table(test_data *data)
     AcpiSdtTable dsdt_table;
     uint32_t addr = data->fadt_table.dsdt;
 
-    memset(&dsdt_table, 0, sizeof(dsdt_table));
-
     test_dst_table(&dsdt_table, addr);
     ACPI_ASSERT_CMP(dsdt_table.header.signature, "DSDT");
 
@@ -245,7 +244,6 @@ static void test_acpi_tables(test_data *data)
     for (i = 0; i < tables_nr; i++) {
         AcpiSdtTable ssdt_table;
 
-        memset(&ssdt_table, 0, sizeof(ssdt_table));
         uint32_t addr = data->rsdt_tables_addr[i + 1]; /* fadt is first */
         test_dst_table(&ssdt_table, addr);
         g_array_append_val(data->tables, ssdt_table);
-- 
2.7.4

  parent reply	other threads:[~2017-07-31 15:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 15:40 [Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is compared to reference table Igor Mammedov
2017-07-31 15:40 ` [Qemu-devel] [PATCH for-2.10 1/5] tests: acpi: move tested tables array allocation outside of test_acpi_dsdt_table() Igor Mammedov
2017-08-02 12:57   ` Marcel Apfelbaum
2017-07-31 15:40 ` Igor Mammedov [this message]
2017-08-02 13:02   ` [Qemu-devel] [PATCH for-2.10 2/5] tests: acpi: init table descriptor in test_dst_table() Marcel Apfelbaum
2017-07-31 15:40 ` [Qemu-devel] [PATCH for-2.10 3/5] tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its usage Igor Mammedov
2017-08-02 13:03   ` Marcel Apfelbaum
2017-07-31 15:40 ` [Qemu-devel] [PATCH for-2.10 4/5] tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables usage Igor Mammedov
2017-08-02 13:04   ` Marcel Apfelbaum
2017-07-31 15:40 ` [Qemu-devel] [PATCH for-2.10 5/5] tests: acpi: fix FADT not being compared to reference table Igor Mammedov
2017-08-02 13:15   ` Marcel Apfelbaum
2017-08-02 14:10     ` Igor Mammedov
2017-08-02 17:47       ` Marcel Apfelbaum
2017-08-01 21:14 ` [Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is " Michael S. Tsirkin
2017-08-02  7:51   ` Igor Mammedov
2017-08-03  1:19     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501515652-33372-3-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).