From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcCyJ-0006xw-SA for qemu-devel@nongnu.org; Mon, 31 Jul 2017 11:51:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcCyH-0002de-C8 for qemu-devel@nongnu.org; Mon, 31 Jul 2017 11:51:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56378) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcCyH-0002dI-6g for qemu-devel@nongnu.org; Mon, 31 Jul 2017 11:51:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 614E724AF7 for ; Mon, 31 Jul 2017 15:41:02 +0000 (UTC) From: Igor Mammedov Date: Mon, 31 Jul 2017 17:40:49 +0200 Message-Id: <1501515652-33372-3-git-send-email-imammedo@redhat.com> In-Reply-To: <1501515652-33372-1-git-send-email-imammedo@redhat.com> References: <1501515652-33372-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH for-2.10 2/5] tests: acpi: init table descriptor in test_dst_table() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Marcel Apfelbaum remove code duplication and make sure that table descriptor passed in for initialization is in expected state. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index b72fa80..adbcc55 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -210,6 +210,7 @@ static void test_dst_table(AcpiSdtTable *sdt_table, uint32_t addr) { uint8_t checksum; + memset(sdt_table, 0, sizeof(*sdt_table)); ACPI_READ_TABLE_HEADER(&sdt_table->header, addr); sdt_table->aml_len = sdt_table->header.length - sizeof(AcpiTableHeader); @@ -228,8 +229,6 @@ static void test_acpi_dsdt_table(test_data *data) AcpiSdtTable dsdt_table; uint32_t addr = data->fadt_table.dsdt; - memset(&dsdt_table, 0, sizeof(dsdt_table)); - test_dst_table(&dsdt_table, addr); ACPI_ASSERT_CMP(dsdt_table.header.signature, "DSDT"); @@ -245,7 +244,6 @@ static void test_acpi_tables(test_data *data) for (i = 0; i < tables_nr; i++) { AcpiSdtTable ssdt_table; - memset(&ssdt_table, 0, sizeof(ssdt_table)); uint32_t addr = data->rsdt_tables_addr[i + 1]; /* fadt is first */ test_dst_table(&ssdt_table, addr); g_array_append_val(data->tables, ssdt_table); -- 2.7.4