From: KONRAD Frederic <frederic.konrad@adacore.com>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, edgar.iglesias@gmail.com,
alistair.francis@xilinx.com, dgilbert@redhat.com,
quintela@redhat.com, frederic.konrad@adacore.com
Subject: [Qemu-devel] [PATCH for-2.10 1/2] mmio-execution: warn the potential developer about migration
Date: Tue, 1 Aug 2017 10:10:47 +0200 [thread overview]
Message-ID: <1501575048-13485-2-git-send-email-frederic.konrad@adacore.com> (raw)
In-Reply-To: <1501575048-13485-1-git-send-email-frederic.konrad@adacore.com>
There are two potential corner cases with mmio-execution:
* It adds a mmio-interface device which will be migrated.
* It modifies the RAMBlock list during live migration which odd
side effects.
Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
---
include/exec/memory.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 400dd44..4ded02c 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -154,6 +154,10 @@ struct MemoryRegionOps {
* @offset is the location of the pointer inside @mr.
*
* Returns a pointer to a location which contains guest code.
+ *
+ * Warning: This breaks migration if used before or during migration
+ * because mmio-interface device will be migrated and because
+ * RAMBlock list _must_ be static during migration.
*/
void *(*request_ptr)(void *opaque, hwaddr addr, unsigned *size,
unsigned *offset);
--
1.8.3.1
next prev parent reply other threads:[~2017-08-01 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 8:10 [Qemu-devel] [PATCH for-2.10 0/2] mmio-execution and migration KONRAD Frederic
2017-08-01 8:10 ` KONRAD Frederic [this message]
2017-08-01 8:10 ` [Qemu-devel] [PATCH for-2.10 2/2] xilinx-spips: add a migration blocker when using mmio_execution KONRAD Frederic
2017-08-01 9:00 ` Peter Maydell
2017-08-01 9:13 ` KONRAD Frederic
2017-08-01 9:30 ` Edgar E. Iglesias
2017-08-01 9:35 ` KONRAD Frederic
2017-08-01 9:41 ` Peter Maydell
2017-08-10 9:11 ` Peter Maydell
2017-08-10 9:22 ` Edgar E. Iglesias
2017-08-10 9:28 ` KONRAD Frederic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501575048-13485-2-git-send-email-frederic.konrad@adacore.com \
--to=frederic.konrad@adacore.com \
--cc=alistair.francis@xilinx.com \
--cc=dgilbert@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).