From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6cPh-0007tI-SV for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:14:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6cPd-0007P3-HL for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:14:41 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:59339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6cPd-0007Or-9y for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:14:37 -0400 Date: Tue, 6 Aug 2013 04:14:36 -0400 (EDT) From: Vadim Rozenfeld Message-ID: <1502115428.9195420.1375776876468.JavaMail.root@redhat.com> In-Reply-To: <20130806080527.GD8218@redhat.com> References: <1375688843-19573-1-git-send-email-hutao@cn.fujitsu.com> <20130805092044.GH2258@redhat.com> <20130805150333.GC877@redhat.com> <20130805160421.GB15901@redhat.com> <20130805183218.GD4244@redhat.com> <20130806073406.GL10891@redhat.com> <1394462966.9192671.1375776197295.JavaMail.root@redhat.com> <20130806080527.GD8218@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Marcel Apfelbaum , seabios@seabios.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" , Gerd Hoffmann , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= ----- Original Message ----- From: "Gleb Natapov" To: "Vadim Rozenfeld" Cc: "Michael S. Tsirkin" , "Daniel P. Berrange" , "Marcel Apfelbaum" , seabios@seabios.org, = qemu-devel@nongnu.org, "Gerd Hoffmann" , "Paolo Bonzini"= , "Eric Blake" , "Andreas F=C3=A4r= ber" Sent: Tuesday, August 6, 2013 6:05:27 PM Subject: Re: [SeaBIOS] [PATCH] don't expose pvpanic device in the UI On Tue, Aug 06, 2013 at 04:03:17AM -0400, Vadim Rozenfeld wrote: >=20 >=20 > ----- Original Message ----- > From: "Gleb Natapov" > To: "Michael S. Tsirkin" > Cc: "Daniel P. Berrange" , "Marcel Apfelbaum" , seabios@seabios.org, qemu-devel@nongnu.org, "Gerd Hoffmann= " , "Paolo Bonzini" , "Eric Blake" = , "Andreas F=C3=A4rber" > Sent: Tuesday, August 6, 2013 5:34:06 PM > Subject: Re: [SeaBIOS] [PATCH] don't expose pvpanic device in the UI >=20 > On Mon, Aug 05, 2013 at 09:32:18PM +0300, Michael S. Tsirkin wrote: > > > > As you see we do let people change many parameters > > > > that do affect activation. > > > By editing XML user can shoot himself in the foot, we should not prev= ent > > > that. > >=20 > > So that's what I'm saying basically. > > At the moment there's no way to remove this device from XML. > > That's just wrong. > Can say the same about PV acpi hotpulg device. >=20 > > In QEMU, we have a standard way to specify devices with -device. > > That should be the interface for anything new really > > unless there's a very compelling reason for something else. > We are disagree on compelling reason in this case obviously. >=20 > > *Not* building it into the PC machine type. > >=20 > > > It should not be required though. > >=20 > > libvirt can pass -device pvpanic by default if nothing > > is specified in XML. That discussion really has to happen > > on libvirt list. > >=20 > As Paolo said you are just pushing the "problem" up the stack > where it is harder to "solve". I put "problem" and "solve" in > quotes because I disagree that the problem that need to be solved > is identified correctly. The correct problem to be solved IMO is > writing Windows driver for the device. >=20 > [VR] > This one shouldn't be too complicated. Can be done on weekend. Gal says he did it already. [VR] If so, we can add it to our build and make it public. -- =09=09=09Gleb.