From: Lan Tianyu <tianyu.lan@intel.com>
To: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org
Cc: Chao Gao <chao.gao@intel.com>,
sstabellini@kernel.org, anthony.perard@citrix.com,
mst@redhat.com, pbonzini@redhat.com, rth@twiddle.net,
ehabkost@redhat.com, marcel@redhat.com, kevin.tian@intel.com,
Lan Tianyu <tianyu.lan@intel.com>
Subject: [Qemu-devel] [PATCH V2 1/3] i386/msi: Correct mask of destination ID in MSI address
Date: Wed, 9 Aug 2017 16:51:20 -0400 [thread overview]
Message-ID: <1502311882-11038-2-git-send-email-tianyu.lan@intel.com> (raw)
In-Reply-To: <1502311882-11038-1-git-send-email-tianyu.lan@intel.com>
From: Chao Gao <chao.gao@intel.com>
According to SDM 10.11.1, only [19:12] bits of MSI address are
Destination ID, change the mask to avoid ambiguity for VT-d spec
has used the bit 4 to indicate a remappable interrupt request.
Signed-off-by: Chao Gao <chao.gao@intel.com>
Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
include/hw/i386/apic-msidef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h
index 8b4d4cc..420b411 100644
--- a/include/hw/i386/apic-msidef.h
+++ b/include/hw/i386/apic-msidef.h
@@ -26,6 +26,6 @@
#define MSI_ADDR_DEST_ID_SHIFT 12
#define MSI_ADDR_DEST_IDX_SHIFT 4
-#define MSI_ADDR_DEST_ID_MASK 0x00ffff0
+#define MSI_ADDR_DEST_ID_MASK 0x000ff000
#endif /* HW_APIC_MSIDEF_H */
--
1.8.3.1
next prev parent reply other threads:[~2017-08-10 2:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 20:51 [Qemu-devel] [PATCH v2 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support Lan Tianyu
2017-08-09 20:51 ` Lan Tianyu [this message]
2017-08-09 20:51 ` [Qemu-devel] [PATCH V2 2/3] xen-pt: bind/unbind interrupt remapping format MSI Lan Tianyu
2017-08-11 18:04 ` Anthony PERARD
2017-08-15 3:10 ` Lan Tianyu
2017-08-21 20:29 ` Stefano Stabellini
2017-08-09 20:51 ` [Qemu-devel] [PATCH V2 3/3] msi: Handle remappable format interrupt request Lan Tianyu
2017-08-10 9:04 ` [Qemu-devel] [PATCH v2 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support Paolo Bonzini
2017-08-10 9:38 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502311882-11038-2-git-send-email-tianyu.lan@intel.com \
--to=tianyu.lan@intel.com \
--cc=anthony.perard@citrix.com \
--cc=chao.gao@intel.com \
--cc=ehabkost@redhat.com \
--cc=kevin.tian@intel.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).