From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dh8aE-0007XK-Mt for qemu-devel@nongnu.org; Mon, 14 Aug 2017 02:10:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dh8a9-0003UD-G3 for qemu-devel@nongnu.org; Mon, 14 Aug 2017 02:10:38 -0400 From: Thomas Huth Date: Mon, 14 Aug 2017 08:10:29 +0200 Message-Id: <1502691029-11112-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH for-2.10] hw/misc/mmio_interface: Return after error_setg() to avoid crash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, KONRAD Frederic , Paolo Bonzini , Peter Maydell QEMU currently abort()s if the user tries to specify the mmio_interface device without parameters: x86_64-softmmu/qemu-system-x86_64 -nographic -device mmio_interface qemu-system-x86_64: /home/thuth/devel/qemu/util/error.c:57: error_setv: Assertion `*errp == ((void *)0)' failed. Aborted (core dumped) This happens because the realize function is trying to set the errp twice in this case. After setting an error, the realize function should immediately return instead. Signed-off-by: Thomas Huth --- hw/misc/mmio_interface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c index 6f004d2..da154e5 100644 --- a/hw/misc/mmio_interface.c +++ b/hw/misc/mmio_interface.c @@ -63,10 +63,12 @@ static void mmio_interface_realize(DeviceState *dev, Error **errp) if (!s->host_ptr) { error_setg(errp, "host_ptr property must be set"); + return; } if (!s->subregion) { error_setg(errp, "subregion property must be set"); + return; } memory_region_init_ram_ptr(&s->ram_mem, OBJECT(s), "ram", -- 1.8.3.1