qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, KONRAD Frederic <frederic.konrad@adacore.com>,
	edgar.iglesias@gmail.com, Thomas Huth <thuth@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable
Date: Tue, 15 Aug 2017 15:30:18 +0100	[thread overview]
Message-ID: <1502807418-9994-1-git-send-email-peter.maydell@linaro.org> (raw)

The mmio-interface device is not something we want to allow
users to create on the command line:
 * it is intended as an implementation detail of the memory
   subsystem, which gets created and deleted by that
   subsystem on demand; it makes no sense to create it
   by hand on the command line
 * it uses a pointer property 'host_ptr' which can't be
   set on the command line

Mark the device as not user_creatable to avoid confusion.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/misc/mmio_interface.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c
index da154e5..894e980 100644
--- a/hw/misc/mmio_interface.c
+++ b/hw/misc/mmio_interface.c
@@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data)
     dc->realize = mmio_interface_realize;
     dc->unrealize = mmio_interface_unrealize;
     dc->props = mmio_interface_properties;
+    /* Reason: pointer property "host_ptr", and this device
+     * is an implementation detail of the memory subsystem,
+     * not intended to be created directly by the user.
+     */
+    dc->user_creatable = false;
 }
 
 static const TypeInfo mmio_interface_info = {
-- 
2.7.4

             reply	other threads:[~2017-08-15 14:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 14:30 Peter Maydell [this message]
2017-08-15 16:16 ` [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable Thomas Huth
2017-08-15 17:16   ` Peter Maydell
2017-08-15 22:58   ` Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502807418-9994-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=edgar.iglesias@gmail.com \
    --cc=frederic.konrad@adacore.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).