From: Wang yong <wang.yong155@zte.com.cn>
To: pbonzini@redhat.com, stefanha@redhat.com, famz@redhat.com,
jasowang@redhat.com, zhangchen.fnst@cn.fujitsu.com,
zhang.zhanghailiang@huawei.com
Cc: wang.yong155@zte.com.cn, wang.guang55@zte.com.cn,
lizhijian@cn.fujitsu.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCHv3 01/03] qemu-iothread: IOThread supports the GMainContext event loop
Date: Thu, 17 Aug 2017 18:58:01 +0800 [thread overview]
Message-ID: <1502967483-4090-2-git-send-email-wang.yong155@zte.com.cn> (raw)
In-Reply-To: <1502967483-4090-1-git-send-email-wang.yong155@zte.com.cn>
From: Wang Yong <wang.yong155@zte.com.cn>
IOThread uses AioContext event loop and does not run a GMainContext.
Therefore,chardev cannot work in IOThread,such as the chardev is
used for colo-compare packets reception.
This patch makes the IOThread run the GMainContext event loop,
chardev and IOThread can work together.
Signed-off-by: Wang Yong <wang.yong155@zte.com.cn>
Signed-off-by: Wang Guang <wang.guang55@zte.com.cn>
---
include/sysemu/iothread.h | 4 ++++
iothread.c | 41 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 45 insertions(+)
diff --git a/include/sysemu/iothread.h b/include/sysemu/iothread.h
index e6da1a4..d2985b3 100644
--- a/include/sysemu/iothread.h
+++ b/include/sysemu/iothread.h
@@ -24,6 +24,9 @@ typedef struct {
QemuThread thread;
AioContext *ctx;
+ GMainContext *worker_context;
+ GMainLoop *main_loop;
+ GOnce once;
QemuMutex init_done_lock;
QemuCond init_done_cond; /* is thread initialization done? */
bool stopping;
@@ -41,5 +44,6 @@ typedef struct {
char *iothread_get_id(IOThread *iothread);
AioContext *iothread_get_aio_context(IOThread *iothread);
void iothread_stop_all(void);
+GMainContext *iothread_get_g_main_context(IOThread *iothread);
#endif /* IOTHREAD_H */
diff --git a/iothread.c b/iothread.c
index beeb870..80ef830 100644
--- a/iothread.c
+++ b/iothread.c
@@ -57,6 +57,20 @@ static void *iothread_run(void *opaque)
while (!atomic_read(&iothread->stopping)) {
aio_poll(iothread->ctx, true);
+
+ if (atomic_read(&iothread->worker_context)) {
+ g_main_context_push_thread_default(iothread->worker_context);
+ iothread->main_loop =
+ g_main_loop_new(iothread->worker_context, TRUE);
+ g_main_loop_run(iothread->main_loop);
+
+ g_main_loop_unref(iothread->main_loop);
+ iothread->main_loop = NULL;
+
+ g_main_context_pop_thread_default(iothread->worker_context);
+ g_main_context_unref(iothread->worker_context);
+ iothread->worker_context = NULL;
+ }
}
rcu_unregister_thread();
@@ -73,6 +87,9 @@ static int iothread_stop(Object *object, void *opaque)
}
iothread->stopping = true;
aio_notify(iothread->ctx);
+ if (atomic_read(&iothread->main_loop)) {
+ g_main_loop_quit(iothread->main_loop);
+ }
qemu_thread_join(&iothread->thread);
return 0;
}
@@ -125,6 +142,7 @@ static void iothread_complete(UserCreatable *obj, Error **errp)
qemu_mutex_init(&iothread->init_done_lock);
qemu_cond_init(&iothread->init_done_cond);
+ iothread->once = (GOnce) G_ONCE_INIT;
/* This assumes we are called from a thread with useful CPU affinity for us
* to inherit.
@@ -309,3 +327,26 @@ void iothread_stop_all(void)
object_child_foreach(container, iothread_stop, NULL);
}
+
+static gpointer iothread_g_main_context_init(gpointer opaque)
+{
+ AioContext *ctx;
+ IOThread *iothread = opaque;
+ GSource *source;
+
+ iothread->worker_context = g_main_context_new();
+
+ ctx = iothread_get_aio_context(iothread);
+ source = aio_get_g_source(ctx);
+ g_source_attach(source, iothread->worker_context);
+ g_source_unref(source);
+
+ return NULL;
+}
+
+GMainContext *iothread_get_g_main_context(IOThread *iothread)
+{
+ g_once(&iothread->once, iothread_g_main_context_init, iothread);
+
+ return iothread->worker_context;
+}
--
1.8.3.1
next prev parent reply other threads:[~2017-08-17 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 10:58 [Qemu-devel] [PATCHv3 00/03] Replace the COLO comparing thread with IOThread Wang yong
2017-08-17 10:58 ` Wang yong [this message]
2017-08-17 11:47 ` [Qemu-devel] [PATCHv3 01/03] qemu-iothread: IOThread supports the GMainContext event loop Paolo Bonzini
2017-08-17 10:58 ` [Qemu-devel] [PATCHv3 02/03] colo-compare: Use IOThread to Check old packet regularly and Process pactkets of the primary Wang yong
2017-08-17 10:58 ` [Qemu-devel] [PATCHv3 03/03] colo-compare: Update the COLO document to add the IOThread configuration Wang yong
2017-08-21 7:41 ` [Qemu-devel] [PATCHv3 00/03] Replace the COLO comparing thread with IOThread Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502967483-4090-2-git-send-email-wang.yong155@zte.com.cn \
--to=wang.yong155@zte.com.cn \
--cc=famz@redhat.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wang.guang55@zte.com.cn \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).