From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
To: qemu devel <qemu-devel@nongnu.org>, Jason Wang <jasowang@redhat.com>
Cc: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: [Qemu-devel] [PATCH V4 3/3] net/colo-compare.c: Fix comments and scheme
Date: Mon, 21 Aug 2017 16:55:19 +0800 [thread overview]
Message-ID: <1503305719-2512-4-git-send-email-zhangchen.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <1503305719-2512-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
---
net/colo-compare.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index a8ccac7..e8af8bb 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -44,7 +44,7 @@
+ CompareState ++
| |
+---------------+ +---------------+ +---------------+
- |conn list +--->conn +--------->conn |
+ | conn list + - > conn + ------- > conn + -- > .......
+---------------+ +---------------+ +---------------+
| | | | | |
+---------------+ +---v----+ +---v----+ +---v----+ +---v----+
@@ -75,14 +75,14 @@ typedef struct CompareState {
SocketReadState sec_rs;
bool vnet_hdr;
- /* connection list: the connections belonged to this NIC could be found
- * in this list.
- * element type: Connection
+ /*
+ * Record the connection that through the NIC
+ * Element type: Connection
*/
GQueue conn_list;
- /* hashtable to save connection */
+ /* Record the connection without repetition */
GHashTable *connection_track_table;
- /* compare thread, a thread for each NIC */
+ /* This thread just do packet compare job */
QemuThread thread;
GMainContext *worker_context;
@@ -444,8 +444,11 @@ static int colo_old_packet_check_one_conn(Connection *conn,
(GCompareFunc)colo_old_packet_check_one);
if (result) {
- /* do checkpoint will flush old packet */
- /* TODO: colo_notify_checkpoint();*/
+ /* Do checkpoint will flush old packet */
+ /*
+ * TODO: Notify colo frame to do checkpoint.
+ * colo_compare_inconsistent_notify();
+ */
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2017-08-21 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 8:55 [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance Zhang Chen
2017-08-21 8:55 ` [Qemu-devel] [PATCH V4 1/3] net/colo-compare.c: Optimize unpredictable tcp options comparison Zhang Chen
2017-09-01 9:35 ` Dou Liyang
2017-09-01 16:02 ` Zhang Chen
2017-09-04 1:52 ` Dou Liyang
2017-08-21 8:55 ` [Qemu-devel] [PATCH V4 2/3] net/colo-compare.c: Adjust net queue pop order for performance Zhang Chen
2017-08-21 8:55 ` Zhang Chen [this message]
2017-08-22 7:16 ` [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance no-reply
2017-08-29 9:01 ` Jason Wang
2017-08-29 10:45 ` Fam Zheng
2017-08-30 1:47 ` Jason Wang
2017-08-29 5:34 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503305719-2512-4-git-send-email-zhangchen.fnst@cn.fujitsu.com \
--to=zhangchen.fnst@cn.fujitsu.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).