From: Gerd Hoffmann <kraxel@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] xhci: guard xhci_kick_epctx against recursive calls for 2.8?
Date: Mon, 21 Aug 2017 14:11:43 +0200 [thread overview]
Message-ID: <1503317503.26016.13.camel@redhat.com> (raw)
In-Reply-To: <93cb052b-78fb-6934-fd35-1d2805090d2a@msgid.tls.msk.ru>
> After applying commit 96d87bdda3919bb16f754b3d3fd1227e1f38f13c:
>
> Author: Gerd Hoffmann <kraxel@redhat.com>
> Date: Thu Feb 2 12:36:12 2017 +0100
>
> xhci: guard xhci_kick_epctx against recursive calls
> to 2.8, to fix the CVE-2017-9375 in 2.8, it starts to fail at
> startup with the assertion failure introduced in this commit:
>
> hw/usb/hcd-xhci.c:2169: xhci_kick_epctx: Assertion `!epctx-
> >kick_active' failed.
>
> The commit itself looks sane, but might be there were other
> fixes before this one, on top of 2.8, required for it to
> functioning properly? I'm not sure I understand the xhci
> machinery right.
ddb603ab6c981c1d67cb42266fc700c33e5b2d8f probably.
13e8ff7abbf1dde46280536ab4fae5012661b8b0 should help too, for cherry-
picking without conflicts.
(just back from vacation).
cheers,
Gerd
prev parent reply other threads:[~2017-08-21 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 10:40 [Qemu-devel] xhci: guard xhci_kick_epctx against recursive calls for 2.8? Michael Tokarev
2017-08-21 12:11 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503317503.26016.13.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).