From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons
Date: Mon, 21 Aug 2017 15:27:25 +0200 [thread overview]
Message-ID: <1503322045.26016.21.camel@redhat.com> (raw)
In-Reply-To: <20170809050846-mutt-send-email-mst@kernel.org>
Hi,
> > .select = VIRTIO_INPUT_CFG_EV_BITS,
> > .subsel = EV_REL,
> > - .size = 1,
> > + .size = 2,
> > .u.bitmap = {
> > - (1 << REL_X) | (1 << REL_Y),
> > + (1 << REL_X) | (1 << REL_Y), (1 << (REL_WHEEL - 8))
>
> Works only when REL_WHEEL is between 8 and 15.
> Add BUILD_BUG_ON?
Not needed IMO, REL_WHEEL value is kernel/userspace abi and will never
change.
>
> > },
> > },
> > { /* end of list */ },
>
> Is it problematic e.g. if you migrate from a host with REL_WHEEL
> to one without? Should we maintain a version without REL_WHEEL
> for old machine types?
Yes, we need a compat property.
Possibly it is easier to fix on the guest side, assuming it is actually
needed (see other reply).
cheers,
Gerd
next prev parent reply other threads:[~2017-08-21 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 22:47 [Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons Marc-André Lureau
2017-08-09 2:33 ` Michael S. Tsirkin
2017-08-21 13:27 ` Gerd Hoffmann [this message]
2017-08-21 13:23 ` Gerd Hoffmann
2017-08-21 13:51 ` Marc-André Lureau
-- strict thread matches above, loose matches on Subject: below --
2017-08-23 13:51 Gerd Hoffmann
2017-08-23 14:38 ` Marc-André Lureau
2017-08-23 14:49 ` Gerd Hoffmann
2017-08-29 7:48 ` Ladi Prosek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503322045.26016.21.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).