From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Antony Pavlov <antonynpavlov@gmail.com>
Subject: [Qemu-devel] [PATCH] hw/arm/digic: Mark device with user_creatable = false
Date: Tue, 22 Aug 2017 15:15:12 +0200 [thread overview]
Message-ID: <1503407712-9894-1-git-send-email-thuth@redhat.com> (raw)
QEMU currently hangs completely when the user is trying to do a
"device_add digic" on an unrelated ARM machine like integratorcp.
Looks like this device is not meant to be hot-pluggable at all, so
let's simply mark it with "user_creatable = false" to avoid the hang.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/arm/digic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/digic.c b/hw/arm/digic.c
index 94f3263..208dfb3 100644
--- a/hw/arm/digic.c
+++ b/hw/arm/digic.c
@@ -101,6 +101,8 @@ static void digic_class_init(ObjectClass *oc, void *data)
DeviceClass *dc = DEVICE_CLASS(oc);
dc->realize = digic_realize;
+ /* Reason: Hangs QEMU when trying to device_add this directly */
+ dc->user_creatable = false;
}
static const TypeInfo digic_type_info = {
--
1.8.3.1
next reply other threads:[~2017-08-22 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 13:15 Thomas Huth [this message]
2017-08-22 13:52 ` [Qemu-devel] [PATCH] hw/arm/digic: Mark device with user_creatable = false Peter Maydell
2017-08-22 14:05 ` Thomas Huth
2017-08-22 14:07 ` Peter Maydell
2017-08-22 14:18 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503407712-9894-1-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=antonynpavlov@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).