From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a GIT submodule
Date: Wed, 23 Aug 2017 16:45:36 +0200 [thread overview]
Message-ID: <1503499536.16071.27.camel@redhat.com> (raw)
In-Reply-To: <20170815100410.GH9674@redhat.com>
Hi,
> > +(cd $source_path && git submodule update --init ui/keycodemapdb)
> > +
>
> Urgh, no, this won't work because of course you don't have to
> have a git checkout when running configure.
>
> Any suggestions on the "best" way to ensure that the ui/keycodemapdb
> git submodule is always checked out, without requiring developers to
> do something manually ?
Don't require it?
The updates shouldn't happen that frequently, IMO we should just commit
the generated files so checking out the submodule is only needed if you
work on the keycodemaps.
cheers,
Gerd
next prev parent reply other threads:[~2017-08-23 14:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 9:36 [Qemu-devel] [PATCH v4 00/12] Convert over to use keycodemapdb Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a GIT submodule Daniel P. Berrange
2017-08-15 10:04 ` Daniel P. Berrange
2017-08-15 10:47 ` Fam Zheng
2017-08-15 10:53 ` Daniel P. Berrange
2017-08-15 12:39 ` Fam Zheng
2017-08-23 14:45 ` Gerd Hoffmann [this message]
2017-08-30 16:37 ` Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 02/12] ui: convert common input code to keycodemapdb Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 03/12] ui: convert key events to QKeyCodes immediately Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 04/12] ui: don't export qemu_input_event_new_key Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 05/12] input: convert virtio-input-hid device to keycodemapdb Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 06/12] input: convert ps2 " Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 07/12] input: convert the adb " Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 08/12] char: convert the escc " Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 09/12] ui: convert cocoa frontend " Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 10/12] ui: convert the SDL2 " Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 11/12] ui: convert GTK and SDL1 frontends " Daniel P. Berrange
2017-08-15 9:36 ` [Qemu-devel] [PATCH v4 12/12] display: convert XenInput keyboard " Daniel P. Berrange
2017-08-15 9:59 ` [Qemu-devel] [PATCH v4 00/12] Convert over to use keycodemapdb no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503499536.16071.27.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).