From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons
Date: Wed, 23 Aug 2017 16:49:10 +0200 [thread overview]
Message-ID: <1503499750.16071.29.camel@redhat.com> (raw)
In-Reply-To: <CAJ+F1CLtURFmjV6JYDtN6AX4_1F9JLAc8WcR62safC4yJQbNfw@mail.gmail.com>
On Wed, 2017-08-23 at 14:38 +0000, Marc-André Lureau wrote:
> Hi
>
> On Wed, Aug 23, 2017 at 3:52 PM Gerd Hoffmann <kraxel@redhat.com>
> wrote:
> > qemu uses wheel-up/down button events for mouse wheel input,
> > however
> > linux applications typically want REL_WHEEL events.
> >
> > This fixes wheel with linux guests. Tested with X11/wayland, and
> > windows virtio-input driver.
> >
> > Based on a patch from Marc.
> > Added property to enable/disable wheel axis.
> > TODO: add compat properties for old machine types.
>
> I guess this patch isn't enough to handle migration? Why not modify
> hw/compat.h with this patch?
Because we are in freeze right now. Just waiting until 2.11 opens and
the 2.11 machine type patch (seen on the list already) is merged, then
I'll do a v2 with the compat fluff. Meanwhile this one should be good
enough for testing.
cheers,
Gerd
next prev parent reply other threads:[~2017-08-23 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 13:51 [Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons Gerd Hoffmann
2017-08-23 14:38 ` Marc-André Lureau
2017-08-23 14:49 ` Gerd Hoffmann [this message]
2017-08-29 7:48 ` Ladi Prosek
-- strict thread matches above, loose matches on Subject: below --
2017-08-08 22:47 Marc-André Lureau
2017-08-09 2:33 ` Michael S. Tsirkin
2017-08-21 13:27 ` Gerd Hoffmann
2017-08-21 13:23 ` Gerd Hoffmann
2017-08-21 13:51 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503499750.16071.29.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).