From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH for-2.11 v3 14/25] tilegx: replace cpu_tilegx_init() with cpu_generic_init()
Date: Thu, 24 Aug 2017 18:31:37 +0200 [thread overview]
Message-ID: <1503592308-93913-15-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1503592308-93913-1-git-send-email-imammedo@redhat.com>
cpu_tilegx_init() always falls back to TYPE_TILEGX_CPU object
regardless of cpu_model. Put fallback logic into
tilegx_cpu_class_by_name() which would translate any cpu_model
into TYPE_TILEGX_CPU class and replace cpu_tilegx_init()
with cpu_generic_init().
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/tilegx/cpu.h | 4 +---
target/tilegx/cpu.c | 11 +++--------
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/target/tilegx/cpu.h b/target/tilegx/cpu.h
index f32be49..71cea04 100644
--- a/target/tilegx/cpu.h
+++ b/target/tilegx/cpu.h
@@ -164,9 +164,7 @@ static inline TileGXCPU *tilegx_env_get_cpu(CPUTLGState *env)
void tilegx_tcg_init(void);
int cpu_tilegx_signal_handler(int host_signum, void *pinfo, void *puc);
-TileGXCPU *cpu_tilegx_init(const char *cpu_model);
-
-#define cpu_init(cpu_model) CPU(cpu_tilegx_init(cpu_model))
+#define cpu_init(cpu_model) cpu_generic_init(TYPE_TILEGX_CPU, cpu_model)
#define cpu_signal_handler cpu_tilegx_signal_handler
diff --git a/target/tilegx/cpu.c b/target/tilegx/cpu.c
index 4532639..7345f5a 100644
--- a/target/tilegx/cpu.c
+++ b/target/tilegx/cpu.c
@@ -52,15 +52,9 @@ static void tilegx_cpu_dump_state(CPUState *cs, FILE *f,
env->pc, env->spregs[TILEGX_SPR_CMPEXCH]);
}
-TileGXCPU *cpu_tilegx_init(const char *cpu_model)
+static ObjectClass *tilegx_cpu_class_by_name(const char *cpu_model)
{
- TileGXCPU *cpu;
-
- cpu = TILEGX_CPU(object_new(TYPE_TILEGX_CPU));
-
- object_property_set_bool(OBJECT(cpu), true, "realized", NULL);
-
- return cpu;
+ return object_class_by_name(TYPE_TILEGX_CPU);
}
static void tilegx_cpu_set_pc(CPUState *cs, vaddr value)
@@ -159,6 +153,7 @@ static void tilegx_cpu_class_init(ObjectClass *oc, void *data)
tcc->parent_reset = cc->reset;
cc->reset = tilegx_cpu_reset;
+ cc->class_by_name = tilegx_cpu_class_by_name;
cc->has_work = tilegx_cpu_has_work;
cc->do_interrupt = tilegx_cpu_do_interrupt;
cc->cpu_exec_interrupt = tilegx_cpu_exec_interrupt;
--
2.7.4
next prev parent reply other threads:[~2017-08-24 16:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 16:31 [Qemu-devel] [PATCH for-2.11 v3 00/25] complete cpu QOMification and remove cpu_FOO_init() helpers Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 01/25] qom: cpu: fix parsed feature string length Igor Mammedov
2017-08-24 17:00 ` Philippe Mathieu-Daudé
2017-08-25 8:11 ` Igor Mammedov
2017-08-25 11:55 ` Philippe Mathieu-Daudé
2017-08-25 13:16 ` Eduardo Habkost
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 02/25] sparc: convert cpu models to SPARC cpu subclasses Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 03/25] sparc: embed sparc_def_t into CPUSPARCState Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 04/25] sparc: convert cpu features to qdev properties Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 05/25] sparc: move adhoc CPUSPARCState initialization to realize time Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 06/25] sparc: make cpu feature parsing property based Igor Mammedov
2017-08-24 16:52 ` Philippe Mathieu-Daudé
2017-08-25 13:11 ` Eduardo Habkost
2017-08-25 14:47 ` [Qemu-devel] [PATCH for-2.11 v4 " Igor Mammedov
2017-08-25 17:56 ` Eduardo Habkost
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 07/25] sparc: replace cpu_sparc_init() with cpu_generic_init() Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 08/25] s390x: replace cpu_s390x_init() " Igor Mammedov
2017-08-31 13:19 ` [Qemu-devel] [PATCH for-2.11 v4 " Igor Mammedov
2017-08-31 13:44 ` David Hildenbrand
2017-08-31 14:04 ` Igor Mammedov
2017-08-31 16:20 ` David Hildenbrand
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 09/25] alpha: replace cpu_alpha_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 10/25] hppa: replace cpu_hppa_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 11/25] m68k: replace cpu_m68k_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 12/25] microblaze: replace cpu_mb_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 13/25] nios2: replace cpu_nios2_init() " Igor Mammedov
2017-08-24 16:31 ` Igor Mammedov [this message]
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 15/25] xtensa: replace cpu_xtensa_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 16/25] tricore: replace cpu_tricore_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 17/25] sh4: replace cpu_sh4_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 18/25] arm: replace cpu_arm_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 19/25] cris: replace cpu_cris_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 20/25] x86: replace cpu_x86_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 21/25] lm32: replace cpu_lm32_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 22/25] moxie: replace cpu_moxie_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 23/25] openrisc: replace cpu_openrisc_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 24/25] unicore32: replace uc32_cpu_init() " Igor Mammedov
2017-08-24 16:31 ` [Qemu-devel] [PATCH for-2.11 v3 25/25] ppc: replace cpu_ppc_init() " Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503592308-93913-15-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).