From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Wang Yong <wang.yong155@zte.com.cn>,
Wang Guang <wang.guang55@zte.com.cn>,
Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL 16/18] qemu-iothread: IOThread supports the GMainContext event loop
Date: Fri, 8 Sep 2017 10:05:22 +0800 [thread overview]
Message-ID: <1504836324-4871-17-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1504836324-4871-1-git-send-email-jasowang@redhat.com>
From: Wang Yong <wang.yong155@zte.com.cn>
IOThread uses AioContext event loop and does not run a GMainContext.
Therefore,chardev cannot work in IOThread,such as the chardev is
used for colo-compare packets reception.
This patch makes the IOThread run the GMainContext event loop,
chardev and IOThread can work together.
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Wang Yong <wang.yong155@zte.com.cn>
Signed-off-by: Wang Guang <wang.guang55@zte.com.cn>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
include/sysemu/iothread.h | 4 ++++
iothread.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 49 insertions(+)
diff --git a/include/sysemu/iothread.h b/include/sysemu/iothread.h
index e6da1a4..d2985b3 100644
--- a/include/sysemu/iothread.h
+++ b/include/sysemu/iothread.h
@@ -24,6 +24,9 @@ typedef struct {
QemuThread thread;
AioContext *ctx;
+ GMainContext *worker_context;
+ GMainLoop *main_loop;
+ GOnce once;
QemuMutex init_done_lock;
QemuCond init_done_cond; /* is thread initialization done? */
bool stopping;
@@ -41,5 +44,6 @@ typedef struct {
char *iothread_get_id(IOThread *iothread);
AioContext *iothread_get_aio_context(IOThread *iothread);
void iothread_stop_all(void);
+GMainContext *iothread_get_g_main_context(IOThread *iothread);
#endif /* IOTHREAD_H */
diff --git a/iothread.c b/iothread.c
index beeb870..44c8944 100644
--- a/iothread.c
+++ b/iothread.c
@@ -57,6 +57,23 @@ static void *iothread_run(void *opaque)
while (!atomic_read(&iothread->stopping)) {
aio_poll(iothread->ctx, true);
+
+ if (atomic_read(&iothread->worker_context)) {
+ GMainLoop *loop;
+
+ g_main_context_push_thread_default(iothread->worker_context);
+ iothread->main_loop =
+ g_main_loop_new(iothread->worker_context, TRUE);
+ loop = iothread->main_loop;
+
+ g_main_loop_run(iothread->main_loop);
+ iothread->main_loop = NULL;
+ g_main_loop_unref(loop);
+
+ g_main_context_pop_thread_default(iothread->worker_context);
+ g_main_context_unref(iothread->worker_context);
+ iothread->worker_context = NULL;
+ }
}
rcu_unregister_thread();
@@ -73,6 +90,9 @@ static int iothread_stop(Object *object, void *opaque)
}
iothread->stopping = true;
aio_notify(iothread->ctx);
+ if (atomic_read(&iothread->main_loop)) {
+ g_main_loop_quit(iothread->main_loop);
+ }
qemu_thread_join(&iothread->thread);
return 0;
}
@@ -125,6 +145,7 @@ static void iothread_complete(UserCreatable *obj, Error **errp)
qemu_mutex_init(&iothread->init_done_lock);
qemu_cond_init(&iothread->init_done_cond);
+ iothread->once = (GOnce) G_ONCE_INIT;
/* This assumes we are called from a thread with useful CPU affinity for us
* to inherit.
@@ -309,3 +330,27 @@ void iothread_stop_all(void)
object_child_foreach(container, iothread_stop, NULL);
}
+
+static gpointer iothread_g_main_context_init(gpointer opaque)
+{
+ AioContext *ctx;
+ IOThread *iothread = opaque;
+ GSource *source;
+
+ iothread->worker_context = g_main_context_new();
+
+ ctx = iothread_get_aio_context(iothread);
+ source = aio_get_g_source(ctx);
+ g_source_attach(source, iothread->worker_context);
+ g_source_unref(source);
+
+ aio_notify(iothread->ctx);
+ return NULL;
+}
+
+GMainContext *iothread_get_g_main_context(IOThread *iothread)
+{
+ g_once(&iothread->once, iothread_g_main_context_init, iothread);
+
+ return iothread->worker_context;
+}
--
2.7.4
next prev parent reply other threads:[~2017-09-08 2:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 2:05 [Qemu-devel] [PULL 00/18] Net patches Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 01/18] net/filter-rewriter.c: Fix rewirter checksum bug when use virtio-net Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 02/18] net/rocker: Remove the dead error handling Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 03/18] net/rocker: Plug memory leak in pci_rocker_init() Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 04/18] net/rocker: Convert to realize() Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 05/18] net/rocker: Fix the unusual macro name Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 06/18] net: rtl8139: do not use old_mmio accesses Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 07/18] MAINTAINERS: Update mail address for COLO Proxy Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 08/18] net/socket: Don't treat odd socket type as SOCK_STREAM Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 09/18] net/socket: Convert several helper functions to Error Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 10/18] net/net: Convert parse_host_port() " Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 11/18] net/socket: Improve -net socket error reporting Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 12/18] e1000: Rename the SEC symbol to SEQEC Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 13/18] net/colo-compare.c: Optimize unpredictable tcp options comparison Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 14/18] net/colo-compare.c: Adjust net queue pop order for performance Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 15/18] net/colo-compare.c: Fix comments and scheme Jason Wang
2017-09-08 2:05 ` Jason Wang [this message]
2017-09-08 2:05 ` [Qemu-devel] [PULL 17/18] colo-compare: Use IOThread to Check old packet regularly and Process pactkets of the primary Jason Wang
2017-09-08 2:05 ` [Qemu-devel] [PULL 18/18] colo-compare: Update the COLO document to add the IOThread configuration Jason Wang
2017-09-08 13:00 ` [Qemu-devel] [PULL 00/18] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504836324-4871-17-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wang.guang55@zte.com.cn \
--cc=wang.yong155@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).