qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>,
	jasowang@redhat.com, jiri@resnulli.us, armbru@redhat.com,
	f4bug@amsat.org
Subject: [Qemu-devel] [PULL 05/18] net/rocker: Fix the unusual macro name
Date: Fri,  8 Sep 2017 10:05:11 +0800	[thread overview]
Message-ID: <1504836324-4871-6-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1504836324-4871-1-git-send-email-jasowang@redhat.com>

From: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>

Cc: jasowang@redhat.com
Cc: jiri@resnulli.us
Cc: armbru@redhat.com
Cc: f4bug@amsat.org
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/net/rocker/rocker.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
index bb38cba..9273473 100644
--- a/hw/net/rocker/rocker.c
+++ b/hw/net/rocker/rocker.c
@@ -69,10 +69,10 @@ struct rocker {
     QLIST_ENTRY(rocker) next;
 };
 
-#define ROCKER "rocker"
+#define TYPE_ROCKER "rocker"
 
-#define to_rocker(obj) \
-    OBJECT_CHECK(Rocker, (obj), ROCKER)
+#define ROCKER(obj) \
+    OBJECT_CHECK(Rocker, (obj), TYPE_ROCKER)
 
 static QLIST_HEAD(, rocker) rockers;
 
@@ -1285,7 +1285,7 @@ static World *rocker_world_type_by_name(Rocker *r, const char *name)
 
 static void pci_rocker_realize(PCIDevice *dev, Error **errp)
 {
-    Rocker *r = to_rocker(dev);
+    Rocker *r = ROCKER(dev);
     const MACAddr zero = { .a = { 0, 0, 0, 0, 0, 0 } };
     const MACAddr dflt = { .a = { 0x52, 0x54, 0x00, 0x12, 0x35, 0x01 } };
     static int sw_index;
@@ -1331,7 +1331,7 @@ static void pci_rocker_realize(PCIDevice *dev, Error **errp)
     /* validate switch properties */
 
     if (!r->name) {
-        r->name = g_strdup(ROCKER);
+        r->name = g_strdup(TYPE_ROCKER);
     }
 
     if (rocker_find(r->name)) {
@@ -1427,7 +1427,7 @@ err_world_type_by_name:
 
 static void pci_rocker_uninit(PCIDevice *dev)
 {
-    Rocker *r = to_rocker(dev);
+    Rocker *r = ROCKER(dev);
     int i;
 
     QLIST_REMOVE(r, next);
@@ -1460,7 +1460,7 @@ static void pci_rocker_uninit(PCIDevice *dev)
 
 static void rocker_reset(DeviceState *dev)
 {
-    Rocker *r = to_rocker(dev);
+    Rocker *r = ROCKER(dev);
     int i;
 
     for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) {
@@ -1498,7 +1498,7 @@ static Property rocker_properties[] = {
 };
 
 static const VMStateDescription rocker_vmsd = {
-    .name = ROCKER,
+    .name = TYPE_ROCKER,
     .unmigratable = 1,
 };
 
@@ -1521,7 +1521,7 @@ static void rocker_class_init(ObjectClass *klass, void *data)
 }
 
 static const TypeInfo rocker_info = {
-    .name          = ROCKER,
+    .name          = TYPE_ROCKER,
     .parent        = TYPE_PCI_DEVICE,
     .instance_size = sizeof(Rocker),
     .class_init    = rocker_class_init,
-- 
2.7.4

  parent reply	other threads:[~2017-09-08  2:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08  2:05 [Qemu-devel] [PULL 00/18] Net patches Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 01/18] net/filter-rewriter.c: Fix rewirter checksum bug when use virtio-net Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 02/18] net/rocker: Remove the dead error handling Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 03/18] net/rocker: Plug memory leak in pci_rocker_init() Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 04/18] net/rocker: Convert to realize() Jason Wang
2017-09-08  2:05 ` Jason Wang [this message]
2017-09-08  2:05 ` [Qemu-devel] [PULL 06/18] net: rtl8139: do not use old_mmio accesses Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 07/18] MAINTAINERS: Update mail address for COLO Proxy Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 08/18] net/socket: Don't treat odd socket type as SOCK_STREAM Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 09/18] net/socket: Convert several helper functions to Error Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 10/18] net/net: Convert parse_host_port() " Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 11/18] net/socket: Improve -net socket error reporting Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 12/18] e1000: Rename the SEC symbol to SEQEC Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 13/18] net/colo-compare.c: Optimize unpredictable tcp options comparison Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 14/18] net/colo-compare.c: Adjust net queue pop order for performance Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 15/18] net/colo-compare.c: Fix comments and scheme Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 16/18] qemu-iothread: IOThread supports the GMainContext event loop Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 17/18] colo-compare: Use IOThread to Check old packet regularly and Process pactkets of the primary Jason Wang
2017-09-08  2:05 ` [Qemu-devel] [PULL 18/18] colo-compare: Update the COLO document to add the IOThread configuration Jason Wang
2017-09-08 13:00 ` [Qemu-devel] [PULL 00/18] Net patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504836324-4871-6-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=armbru@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=jiri@resnulli.us \
    --cc=maozy.fnst@cn.fujitsu.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).