From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH 3/7] target/arm: Get PRECISERR and IBUSERR the right way round
Date: Mon, 11 Sep 2017 14:52:06 +0100 [thread overview]
Message-ID: <1505137930-13255-4-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1505137930-13255-1-git-send-email-peter.maydell@linaro.org>
For a bus fault, the M profile BFSR bit PRECISERR means a bus
fault on a data access, and IBUSERR means a bus fault on an
instruction access. We had these the wrong way around; fix this.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/arm/helper.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 668e367..1741e0d 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -6430,15 +6430,15 @@ void arm_v7m_cpu_do_interrupt(CPUState *cs)
case 0x8: /* External Abort */
switch (cs->exception_index) {
case EXCP_PREFETCH_ABORT:
- env->v7m.cfsr[M_REG_NS] |= R_V7M_CFSR_PRECISERR_MASK;
- qemu_log_mask(CPU_LOG_INT, "...with CFSR.PRECISERR\n");
+ env->v7m.cfsr[M_REG_NS] |= R_V7M_CFSR_IBUSERR_MASK;
+ qemu_log_mask(CPU_LOG_INT, "...with CFSR.IBUSERR\n");
break;
case EXCP_DATA_ABORT:
env->v7m.cfsr[M_REG_NS] |=
- (R_V7M_CFSR_IBUSERR_MASK | R_V7M_CFSR_BFARVALID_MASK);
+ (R_V7M_CFSR_PRECISERR_MASK | R_V7M_CFSR_BFARVALID_MASK);
env->v7m.bfar = env->exception.vaddress;
qemu_log_mask(CPU_LOG_INT,
- "...with CFSR.IBUSERR and BFAR 0x%x\n",
+ "...with CFSR.PRECISERR and BFAR 0x%x\n",
env->v7m.bfar);
break;
}
--
2.7.4
next prev parent reply other threads:[~2017-09-11 13:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 13:52 [Qemu-devel] [PATCH 0/7] ARMv8M: some bugfixes and prep. cleanup Peter Maydell
2017-09-11 13:52 ` [Qemu-devel] [PATCH 1/7] target/arm: Use M_REG_NUM_BANKS rather than hardcoding 2 Peter Maydell
2017-09-11 14:59 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-09-11 17:32 ` Alistair Francis
2017-09-11 13:52 ` [Qemu-devel] [PATCH 2/7] target/arm: Clear exclusive monitor on v7M reset, exception entry/exit Peter Maydell
2017-09-11 17:33 ` Alistair Francis
2017-09-13 15:55 ` Richard Henderson
2017-09-11 13:52 ` Peter Maydell [this message]
2017-09-11 17:38 ` [Qemu-devel] [PATCH 3/7] target/arm: Get PRECISERR and IBUSERR the right way round Alistair Francis
2017-09-13 15:57 ` Richard Henderson
2017-09-11 13:52 ` [Qemu-devel] [PATCH 4/7] nvic: Don't apply group priority mask to negative priorities Peter Maydell
2017-09-13 15:58 ` Richard Henderson
2017-09-11 13:52 ` [Qemu-devel] [PATCH 5/7] target/arm: Remove unnecessary '| 0xf0000000' from do_v7m_exception_exit() Peter Maydell
2017-09-11 17:41 ` Alistair Francis
2017-09-13 16:36 ` Richard Henderson
2017-09-11 13:52 ` [Qemu-devel] [PATCH 6/7] target/arm: Add and use defines for EXCRET constants Peter Maydell
2017-09-11 17:43 ` Alistair Francis
2017-09-11 13:52 ` [Qemu-devel] [PATCH 7/7] target/arm: Rename 'type' to 'excret' in do_v7m_exception_exit() Peter Maydell
2017-09-11 15:03 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-09-11 17:45 ` Alistair Francis
2017-09-13 16:41 ` [Qemu-devel] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505137930-13255-4-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).