qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: wexu@redhat.com
To: qemu-devel@nongnu.org
Cc: jasowang@redhat.com, marcel@redhat.com,
	alex.williamson@redhat.com, Wei Xu <wexu@redhat.com>
Subject: [Qemu-devel] [Patch 3/3] vfio: remove checking duplicated vfio device
Date: Tue, 12 Sep 2017 02:56:32 +0800	[thread overview]
Message-ID: <1505156192-18994-4-git-send-email-wexu@redhat.com> (raw)
In-Reply-To: <1505156192-18994-1-git-send-email-wexu@redhat.com>

From: Wei Xu <wexu@redhat.com>

This has been done when introducing 'vfio_lookup_as()'
patch as a side work to reuse the loop.

Signed-off-by: Wei Xu <wexu@redhat.com>
---
 hw/vfio/pci.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 856cefd..d78f756 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -2632,7 +2632,6 @@ static void vfio_unregister_req_notifier(VFIOPCIDevice *vdev)
 static void vfio_realize(PCIDevice *pdev, Error **errp)
 {
     VFIOPCIDevice *vdev = DO_UPCAST(VFIOPCIDevice, pdev, pdev);
-    VFIODevice *vbasedev_iter;
     VFIOGroup *group;
     char *tmp, group_path[PATH_MAX], *group_name;
     Error *err = NULL;
@@ -2697,14 +2696,6 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
         goto error;
     }
 
-    QLIST_FOREACH(vbasedev_iter, &group->device_list, next) {
-        if (strcmp(vbasedev_iter->name, vdev->vbasedev.name) == 0) {
-            error_setg(errp, "device is already attached");
-            vfio_put_group(group);
-            goto error;
-        }
-    }
-
     ret = vfio_get_device(group, vdev->vbasedev.name, &vdev->vbasedev, errp);
     if (ret) {
         vfio_put_group(group);
-- 
1.8.3.1

  parent reply	other threads:[~2017-09-11 18:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 18:56 [Qemu-devel] [Patch 0/3] vfio: reusing address space for the same iommu group devices wexu
2017-09-11 18:51 ` no-reply
2017-09-11 18:56 ` [Qemu-devel] [Patch 1/3] vfio: reusing address space for the same IOMMU " wexu
2017-09-11 18:56 ` [Qemu-devel] [Patch 2/3] vfio: invoke looking up address space wexu
2017-09-11 18:56 ` wexu [this message]
2017-09-11 19:18 ` [Qemu-devel] [Patch 0/3] vfio: reusing address space for the same iommu group devices Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505156192-18994-4-git-send-email-wexu@redhat.com \
    --to=wexu@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=marcel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).