From: jincheng.miao@gmail.com
To: rth@twiddle.net, peter.maydell@linaro.org, sw@weilnetz.de
Cc: qemu-devel@nongnu.org, Jincheng Miao <jincheng.miao@gmail.com>
Subject: [Qemu-devel] [PATCH] tcg: Fix tci build
Date: Tue, 12 Sep 2017 08:17:39 +0800 [thread overview]
Message-ID: <1505175459-27177-1-git-send-email-jincheng.miao@gmail.com> (raw)
From: Jincheng Miao <jincheng.miao@gmail.com>
The previous commit 659ef5cbb8 enable LDST_LABELS in tci target,
but which causes tci build error like:
tcg/tcg.c:116:13: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror]
static bool tcg_out_ldst_finalize(TCGContext *s);
^
cc1: all warnings being treated as errors
make[1]: *** [tcg/tcg.o] Error 1
make: *** [subdir-x86_64-softmmu] Error 2
If this macro is not used in tci, we could just delete it.
Signed-off-by: Jincheng Miao <jincheng.miao@gmail.com>
---
tcg/tci/tcg-target.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
index 5d692e1..26140d7 100644
--- a/tcg/tci/tcg-target.h
+++ b/tcg/tci/tcg-target.h
@@ -206,8 +206,4 @@ static inline void tb_target_set_jmp_target(uintptr_t tc_ptr,
/* no need to flush icache explicitly */
}
-#ifdef CONFIG_SOFTMMU
-#define TCG_TARGET_NEED_LDST_LABELS
-#endif
-
#endif /* TCG_TARGET_H */
--
1.8.3.1
next reply other threads:[~2017-09-11 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 0:17 jincheng.miao [this message]
2017-09-11 17:29 ` [Qemu-devel] [PATCH] tcg: Fix tci build Alistair Francis
2017-09-12 2:11 ` Jincheng Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505175459-27177-1-git-send-email-jincheng.miao@gmail.com \
--to=jincheng.miao@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).