* Re: [Qemu-devel] [PATCH] tcg: Fix tci build
2017-09-12 0:17 [Qemu-devel] [PATCH] tcg: Fix tci build jincheng.miao
@ 2017-09-11 17:29 ` Alistair Francis
2017-09-12 2:11 ` Jincheng Miao
0 siblings, 1 reply; 3+ messages in thread
From: Alistair Francis @ 2017-09-11 17:29 UTC (permalink / raw)
To: jincheng.miao
Cc: Richard Henderson, Peter Maydell, Stefan Weil,
qemu-devel@nongnu.org Developers
On Mon, Sep 11, 2017 at 5:17 PM, <jincheng.miao@gmail.com> wrote:
> From: Jincheng Miao <jincheng.miao@gmail.com>
>
> The previous commit 659ef5cbb8 enable LDST_LABELS in tci target,
> but which causes tci build error like:
> tcg/tcg.c:116:13: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror]
> static bool tcg_out_ldst_finalize(TCGContext *s);
> ^
> cc1: all warnings being treated as errors
> make[1]: *** [tcg/tcg.o] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
>
> If this macro is not used in tci, we could just delete it.
>
> Signed-off-by: Jincheng Miao <jincheng.miao@gmail.com>
Thank you for the patch!
This looks good, unfortunately someone else had already sent the same
fix. You can review their patch and add your Reviewed by line to that
patch, that will help get the fix merged.
You can see their patch here: https://patchwork.kernel.org/patch/9946503/
Thanks,
Alistair
> ---
> tcg/tci/tcg-target.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
> index 5d692e1..26140d7 100644
> --- a/tcg/tci/tcg-target.h
> +++ b/tcg/tci/tcg-target.h
> @@ -206,8 +206,4 @@ static inline void tb_target_set_jmp_target(uintptr_t tc_ptr,
> /* no need to flush icache explicitly */
> }
>
> -#ifdef CONFIG_SOFTMMU
> -#define TCG_TARGET_NEED_LDST_LABELS
> -#endif
> -
> #endif /* TCG_TARGET_H */
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] tcg: Fix tci build
@ 2017-09-12 0:17 jincheng.miao
2017-09-11 17:29 ` Alistair Francis
0 siblings, 1 reply; 3+ messages in thread
From: jincheng.miao @ 2017-09-12 0:17 UTC (permalink / raw)
To: rth, peter.maydell, sw; +Cc: qemu-devel, Jincheng Miao
From: Jincheng Miao <jincheng.miao@gmail.com>
The previous commit 659ef5cbb8 enable LDST_LABELS in tci target,
but which causes tci build error like:
tcg/tcg.c:116:13: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror]
static bool tcg_out_ldst_finalize(TCGContext *s);
^
cc1: all warnings being treated as errors
make[1]: *** [tcg/tcg.o] Error 1
make: *** [subdir-x86_64-softmmu] Error 2
If this macro is not used in tci, we could just delete it.
Signed-off-by: Jincheng Miao <jincheng.miao@gmail.com>
---
tcg/tci/tcg-target.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
index 5d692e1..26140d7 100644
--- a/tcg/tci/tcg-target.h
+++ b/tcg/tci/tcg-target.h
@@ -206,8 +206,4 @@ static inline void tb_target_set_jmp_target(uintptr_t tc_ptr,
/* no need to flush icache explicitly */
}
-#ifdef CONFIG_SOFTMMU
-#define TCG_TARGET_NEED_LDST_LABELS
-#endif
-
#endif /* TCG_TARGET_H */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: Fix tci build
2017-09-11 17:29 ` Alistair Francis
@ 2017-09-12 2:11 ` Jincheng Miao
0 siblings, 0 replies; 3+ messages in thread
From: Jincheng Miao @ 2017-09-12 2:11 UTC (permalink / raw)
To: Alistair Francis
Cc: Richard Henderson, Peter Maydell, Stefan Weil,
qemu-devel@nongnu.org Developers
Good to know, and thanks for your review and remind.
Regards,
Jincheng Miao
On Tue, Sep 12, 2017 at 1:29 AM, Alistair Francis <alistair23@gmail.com> wrote:
> On Mon, Sep 11, 2017 at 5:17 PM, <jincheng.miao@gmail.com> wrote:
>> From: Jincheng Miao <jincheng.miao@gmail.com>
>>
>> The previous commit 659ef5cbb8 enable LDST_LABELS in tci target,
>> but which causes tci build error like:
>> tcg/tcg.c:116:13: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror]
>> static bool tcg_out_ldst_finalize(TCGContext *s);
>> ^
>> cc1: all warnings being treated as errors
>> make[1]: *** [tcg/tcg.o] Error 1
>> make: *** [subdir-x86_64-softmmu] Error 2
>>
>> If this macro is not used in tci, we could just delete it.
>>
>> Signed-off-by: Jincheng Miao <jincheng.miao@gmail.com>
>
> Thank you for the patch!
>
> This looks good, unfortunately someone else had already sent the same
> fix. You can review their patch and add your Reviewed by line to that
> patch, that will help get the fix merged.
>
> You can see their patch here: https://patchwork.kernel.org/patch/9946503/
>
> Thanks,
> Alistair
>
>> ---
>> tcg/tci/tcg-target.h | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
>> index 5d692e1..26140d7 100644
>> --- a/tcg/tci/tcg-target.h
>> +++ b/tcg/tci/tcg-target.h
>> @@ -206,8 +206,4 @@ static inline void tb_target_set_jmp_target(uintptr_t tc_ptr,
>> /* no need to flush icache explicitly */
>> }
>>
>> -#ifdef CONFIG_SOFTMMU
>> -#define TCG_TARGET_NEED_LDST_LABELS
>> -#endif
>> -
>> #endif /* TCG_TARGET_H */
>> --
>> 1.8.3.1
>>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-12 2:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-12 0:17 [Qemu-devel] [PATCH] tcg: Fix tci build jincheng.miao
2017-09-11 17:29 ` Alistair Francis
2017-09-12 2:11 ` Jincheng Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).