From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure
Date: Thu, 14 Sep 2017 10:36:45 +0200 [thread overview]
Message-ID: <1505378205.31557.3.camel@redhat.com> (raw)
In-Reply-To: <47d72e62-8ebb-3b45-3efe-ab5f98ed4f39@redhat.com>
Hi,
> > + --firmwarepath=PATH search PATH for firmware files
>
> Maybe --firmwaredir or --with-firmwaredir (because firmwaredir is not
> one of the "standard" directories)?
I've intentionally named this "path" because it can actually have
multiple directories.
Or do you mean something else? If so --verbose please.
> > + /* add configured firmware directories */
> > + dirs = g_strsplit(CONFIG_QEMU_FIRMWAREPATH, ":", 0);
>
> Windows probably wants to use ; here, so you can use
> G_SEARCHPATH_SEPARATOR_S instead of ":".
Ah, cool, didn't know this exists. Fixing ...
cheers,
Gerd
next prev parent reply other threads:[~2017-09-14 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 12:09 [Qemu-devel] [PATCH 0/2] Add --firmwarepath to configure Gerd Hoffmann
2017-09-13 12:09 ` [Qemu-devel] [PATCH 1/2] add qemu_add_data_dir() Gerd Hoffmann
2017-09-13 12:09 ` [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure Gerd Hoffmann
2017-09-13 20:43 ` Paolo Bonzini
2017-09-14 8:36 ` Gerd Hoffmann [this message]
2017-09-14 11:37 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505378205.31557.3.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).