From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Eric Blake" <eblake@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"John Snow" <jsnow@redhat.com>
Subject: [Qemu-devel] [PULL 8/9] libqtest: Remove dead qtest_instances variable
Date: Fri, 15 Sep 2017 10:02:28 +0200 [thread overview]
Message-ID: <1505462549-27298-9-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1505462549-27298-1-git-send-email-thuth@redhat.com>
From: Eric Blake <eblake@redhat.com>
Prior to commit 063c23d9, we were tracking a list of parallel
qtest objects, in order to safely clean up a SIGABRT handler
only after the last connection quits. But when we switched to
more of glib's infrastructure, the list became dead code that
is never assigned to.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/libqtest.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 3daa0e3..cbd7094 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -42,7 +42,6 @@ struct QTestState
};
static GHookList abrt_hooks;
-static GList *qtest_instances;
static struct sigaction sigact_old;
#define g_assert_no_errno(ret) do { \
@@ -247,13 +246,10 @@ QTestState *qtest_init(const char *extra_args)
void qtest_quit(QTestState *s)
{
- qtest_instances = g_list_remove(qtest_instances, s);
g_hook_destroy_link(&abrt_hooks, g_hook_find_data(&abrt_hooks, TRUE, s));
/* Uninstall SIGABRT handler on last instance */
- if (!qtest_instances) {
- cleanup_sigabrt_handler();
- }
+ cleanup_sigabrt_handler();
kill_qemu(s);
close(s->fd);
--
1.8.3.1
next prev parent reply other threads:[~2017-09-15 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 8:02 [Qemu-devel] [PULL 0/9] Fixes and improvements for various qtests Thomas Huth
2017-09-15 8:02 ` [Qemu-devel] [PULL 1/9] tests: Introduce generic device hot-plug/hot-unplug functions Thomas Huth
2017-09-15 8:02 ` [Qemu-devel] [PULL 2/9] tests/test-hmp: Remove puv3 and tricore_testboard from the blacklist Thomas Huth
2017-09-15 8:02 ` [Qemu-devel] [PULL 3/9] tests/libqtest: Use a proper error message if QTEST_QEMU_BINARY is missing Thomas Huth
2017-09-15 8:02 ` [Qemu-devel] [PULL 4/9] tests: Fix broken ivshmem-server-msi/-irq tests Thomas Huth
2017-09-15 8:02 ` [Qemu-devel] [PULL 5/9] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code Thomas Huth
2017-09-15 8:02 ` [Qemu-devel] [PULL 6/9] qtest: Don't perform side effects inside assertion Thomas Huth
2017-09-15 8:02 ` [Qemu-devel] [PULL 7/9] numa-test: Use hmp() Thomas Huth
2017-09-15 8:02 ` Thomas Huth [this message]
2017-09-15 8:02 ` [Qemu-devel] [PULL 9/9] qtest: Avoid passing raw strings through hmp() Thomas Huth
2017-09-15 21:32 ` [Qemu-devel] [PULL 0/9] Fixes and improvements for various qtests Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505462549-27298-9-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).