From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dslac-00081U-8J for qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:03:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dslaW-0000lz-Ap for qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:03:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51688) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dslaW-0000ls-5J for qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:03:00 -0400 From: Thomas Huth Date: Fri, 15 Sep 2017 10:02:28 +0200 Message-Id: <1505462549-27298-9-git-send-email-thuth@redhat.com> In-Reply-To: <1505462549-27298-1-git-send-email-thuth@redhat.com> References: <1505462549-27298-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 8/9] libqtest: Remove dead qtest_instances variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Eric Blake , "Dr. David Alan Gilbert" , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , John Snow From: Eric Blake Prior to commit 063c23d9, we were tracking a list of parallel qtest objects, in order to safely clean up a SIGABRT handler only after the last connection quits. But when we switched to more of glib's infrastructure, the list became dead code that is never assigned to. Signed-off-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/libqtest.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3daa0e3..cbd7094 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -42,7 +42,6 @@ struct QTestState }; =20 static GHookList abrt_hooks; -static GList *qtest_instances; static struct sigaction sigact_old; =20 #define g_assert_no_errno(ret) do { \ @@ -247,13 +246,10 @@ QTestState *qtest_init(const char *extra_args) =20 void qtest_quit(QTestState *s) { - qtest_instances =3D g_list_remove(qtest_instances, s); g_hook_destroy_link(&abrt_hooks, g_hook_find_data(&abrt_hooks, TRUE,= s)); =20 /* Uninstall SIGABRT handler on last instance */ - if (!qtest_instances) { - cleanup_sigabrt_handler(); - } + cleanup_sigabrt_handler(); =20 kill_qemu(s); close(s->fd); --=20 1.8.3.1