From: Mohammed Gamal <mgamal@redhat.com>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, mst@redhat.com, thuth@redhat.com,
peterx@redhat.com, Mohammed Gamal <mgamal@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] x86_iommu: Fix segfault when starting on non-PCI machines
Date: Fri, 15 Sep 2017 13:13:44 +0200 [thread overview]
Message-ID: <1505474026-13151-1-git-send-email-mgamal@redhat.com> (raw)
Starting qemu with
qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu
leads to a segfault. The code assume PCI bus is present and
tries to access the bus structure without checking.
The patch series moves the error checks from vtd_realize()
and amdvi_realize() to the generic x86_iommu_realize() and
adds a check for PCI bus presence.
Mohammed Gamal (2):
x86_iommu: Move machine check to x86_iommu_realize()
x86_iommu: check if machine has PCI bus
hw/i386/amd_iommu.c | 10 +---------
hw/i386/intel_iommu.c | 10 +---------
hw/i386/x86-iommu.c | 13 +++++++++++++
3 files changed, 15 insertions(+), 18 deletions(-)
--
1.8.3.1
next reply other threads:[~2017-09-15 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 11:13 Mohammed Gamal [this message]
2017-09-15 11:13 ` [Qemu-devel] [PATCH 1/2] x86_iommu: Move machine check to x86_iommu_realize() Mohammed Gamal
2017-09-15 13:52 ` Peter Xu
2017-09-15 13:55 ` Peter Xu
2017-09-15 11:13 ` [Qemu-devel] [PATCH 2/2] x86_iommu: check if machine has PCI bus Mohammed Gamal
2017-09-15 13:52 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505474026-13151-1-git-send-email-mgamal@redhat.com \
--to=mgamal@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).