From: Ian Jackson <ian.jackson@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: xen-devel@nongnu.org, Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [Qemu-devel] [PATCH RFC 2/6] xen: defer call to xen_restrict until running
Date: Fri, 15 Sep 2017 19:09:55 +0100 [thread overview]
Message-ID: <1505498999-17427-3-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1505498999-17427-1-git-send-email-ian.jackson@eu.citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
hw/i386/xen/xen-hvm.c | 8 --------
hw/xen/xen-common.c | 10 ++++++++++
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index d9ccd5d..7b60ec6 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -1254,14 +1254,6 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion **ram_memory)
goto err;
}
- if (xen_domid_restrict) {
- rc = xen_restrict(xen_domid);
- if (rc < 0) {
- error_report("failed to restrict: error %d", errno);
- goto err;
- }
- }
-
xen_create_ioreq_server(xen_domid, &state->ioservid);
state->exit.notify = xen_exit_notifier;
diff --git a/hw/xen/xen-common.c b/hw/xen/xen-common.c
index 632a938..dfee53e 100644
--- a/hw/xen/xen-common.c
+++ b/hw/xen/xen-common.c
@@ -111,9 +111,19 @@ static void xenstore_record_dm_state(struct xs_handle *xs, const char *state)
static void xen_change_state_handler(void *opaque, int running,
RunState state)
{
+ int rc;
+
if (running) {
/* record state running */
xenstore_record_dm_state(xenstore, "running");
+
+ if (xen_domid_restrict) {
+ rc = xen_restrict(xen_domid);
+ if (rc < 0) {
+ perror("xen: failed to restrict");
+ exit(1);
+ }
+ }
}
}
--
2.1.4
next prev parent reply other threads:[~2017-09-15 18:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 18:09 [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements Ian Jackson
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore Ian Jackson
2017-09-22 12:14 ` Juergen Gross
2017-09-25 15:08 ` Anthony PERARD
2017-09-25 15:16 ` Juergen Gross
2017-09-25 15:01 ` Anthony PERARD
2017-10-03 17:25 ` Ian Jackson
2017-09-15 18:09 ` Ian Jackson [this message]
2017-09-25 16:08 ` [Qemu-devel] [PATCH RFC 2/6] xen: defer call to xen_restrict until running Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 3/6] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2017-09-25 16:15 ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 4/6] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2017-09-25 16:28 ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2017-09-25 16:32 ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 6/6] os-posix: Provide new -runasid option Ian Jackson
2017-09-15 18:17 ` [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements no-reply
2017-09-15 18:17 ` no-reply
2017-10-03 17:24 ` Ian Jackson
2017-10-04 5:41 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505498999-17427-3-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).