qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: xen-devel@nongnu.org, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [Qemu-devel] [PATCH RFC 3/6] xen: restrict: use xentoolcore_restrict_all
Date: Fri, 15 Sep 2017 19:09:56 +0100	[thread overview]
Message-ID: <1505498999-17427-4-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1505498999-17427-1-git-send-email-ian.jackson@eu.citrix.com>

And insist that it works.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 include/hw/xen/xen_common.h | 26 ++------------------------
 1 file changed, 2 insertions(+), 24 deletions(-)

diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
index 86c7f26..b6cb024 100644
--- a/include/hw/xen/xen_common.h
+++ b/include/hw/xen/xen_common.h
@@ -12,6 +12,7 @@
 
 #include <xenctrl.h>
 #include <xenstore.h>
+#include <xentoolcore.h>
 #include <xen/io/xenbus.h>
 
 #include "hw/hw.h"
@@ -289,30 +290,7 @@ static inline int xen_modified_memory(domid_t domid, uint64_t first_pfn,
 
 static inline int xen_restrict(domid_t domid)
 {
-    int rc;
-
-    /* Attempt to restrict devicemodel operations */
-    rc = xendevicemodel_restrict(xen_dmod, domid);
-    trace_xen_domid_restrict(rc ? errno : 0);
-
-    if (rc < 0) {
-        /*
-         * If errno is ENOTTY then restriction is not implemented so
-         * there's no point in trying to restrict other types of
-         * operation, but it should not be treated as a failure.
-         */
-        if (errno == ENOTTY) {
-            return 0;
-        }
-
-        return rc;
-    }
-
-    /* Restrict foreignmemory operations */
-    rc = xenforeignmemory_restrict(xen_fmem, domid);
-    trace_xen_domid_restrict(rc ? errno : 0);
-
-    return rc;
+    return xentoolcore_restrict_all(domid);
 }
 
 void destroy_hvm_domain(bool reboot);
-- 
2.1.4

  parent reply	other threads:[~2017-09-15 18:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15 18:09 [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements Ian Jackson
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore Ian Jackson
2017-09-22 12:14   ` Juergen Gross
2017-09-25 15:08     ` Anthony PERARD
2017-09-25 15:16       ` Juergen Gross
2017-09-25 15:01   ` Anthony PERARD
2017-10-03 17:25     ` Ian Jackson
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 2/6] xen: defer call to xen_restrict until running Ian Jackson
2017-09-25 16:08   ` Anthony PERARD
2017-09-15 18:09 ` Ian Jackson [this message]
2017-09-25 16:15   ` [Qemu-devel] [PATCH RFC 3/6] xen: restrict: use xentoolcore_restrict_all Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 4/6] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2017-09-25 16:28   ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2017-09-25 16:32   ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 6/6] os-posix: Provide new -runasid option Ian Jackson
2017-09-15 18:17 ` [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements no-reply
2017-09-15 18:17 ` no-reply
2017-10-03 17:24   ` Ian Jackson
2017-10-04  5:41     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505498999-17427-4-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=jgross@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).