qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: xen-devel@nongnu.org, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicemodel_shutdown
Date: Fri, 15 Sep 2017 19:09:58 +0100	[thread overview]
Message-ID: <1505498999-17427-6-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1505498999-17427-1-git-send-email-ian.jackson@eu.citrix.com>

xc_interface_open etc. is not going to work if we have dropped
privilege, but xendevicemodel_shutdown will if everything is new
enough.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 hw/i386/xen/xen-hvm.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index 83420cd..639425a 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -1386,9 +1386,18 @@ void destroy_hvm_domain(bool reboot)
 {
     xc_interface *xc_handle;
     int sts;
+    int rc;
 
     unsigned int reason = reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff;
 
+    if (xen_dmod) {
+        rc = xendevicemodel_shutdown(xen_dmod, xen_domid, reason);
+        if (!rc)
+            return;
+        perror("xendevicemodel_shutdown failed");
+        /* well, try the old thing then */
+    }
+
     xc_handle = xc_interface_open(0, 0, 0);
     if (xc_handle == NULL) {
         fprintf(stderr, "Cannot acquire xenctrl handle\n");
-- 
2.1.4

  parent reply	other threads:[~2017-09-15 18:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15 18:09 [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements Ian Jackson
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore Ian Jackson
2017-09-22 12:14   ` Juergen Gross
2017-09-25 15:08     ` Anthony PERARD
2017-09-25 15:16       ` Juergen Gross
2017-09-25 15:01   ` Anthony PERARD
2017-10-03 17:25     ` Ian Jackson
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 2/6] xen: defer call to xen_restrict until running Ian Jackson
2017-09-25 16:08   ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 3/6] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2017-09-25 16:15   ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 4/6] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2017-09-25 16:28   ` Anthony PERARD
2017-09-15 18:09 ` Ian Jackson [this message]
2017-09-25 16:32   ` [Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 6/6] os-posix: Provide new -runasid option Ian Jackson
2017-09-15 18:17 ` [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements no-reply
2017-09-15 18:17 ` no-reply
2017-10-03 17:24   ` Ian Jackson
2017-10-04  5:41     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505498999-17427-6-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=jgross@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).