From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW3iY-0005R2-Bf for qemu-devel@nongnu.org; Tue, 15 Oct 2013 08:27:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VW3iU-0001Te-6v for qemu-devel@nongnu.org; Tue, 15 Oct 2013 08:27:18 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:50450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW3iT-0001TZ-Uw for qemu-devel@nongnu.org; Tue, 15 Oct 2013 08:27:14 -0400 Date: Tue, 15 Oct 2013 08:27:11 -0400 (EDT) From: Vadim Rozenfeld Message-ID: <1505501645.7839341.1381840031788.JavaMail.root@redhat.com> In-Reply-To: <20131014140911.1ef2c25d@nial.usersys.redhat.com> References: <1373927181-24247-1-git-send-email-imammedo@redhat.com> <20131014140911.1ef2c25d@nial.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU features into properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Paolo Bonzini , Anthony Liguori , Eduardo Habkost , Andreas =?utf-8?Q?F=C3=A4rber?= , qemu-devel@nongnu.org ----- Original Message ----- From: "Igor Mammedov" To: "Igor Mammedov" Cc: "Anthony Liguori" , "Eduardo Habkost" , qemu-devel@nongnu.org, "Vadim Rozenfeld" , = "Paolo Bonzini" , "Andreas F=C3=A4rber" Sent: Monday, October 14, 2013 3:09:11 PM Subject: Re: [Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU= features into properties On Tue, 16 Jul 2013 00:25:53 +0200 Igor Mammedov wrote: > It's reordered and rebased v8 plus CPUID feature bits conversion to prope= rties > and cleanups that are removing unused anymore *_feature_name arrays. >=20 > dynamic =3D> static properties conversion is still making sense as cleanu= p of > initfn(), consolidating all properties in one place and making uniform > property setters signatures, so it was kept. >=20 > hyperv and dynamic =3D> static properties conversion are covered by virt-= test's > qemu_cpu test group. >=20 > On top of that, CPUID feature bits conversion and cleanups it's allowed. >=20 > git for testing: https://github.com/imammedo/qemu/tree/x86-cpu-properties= .v9 >=20 > v8-v9: > * reorder hyperv/check/force and cpu_x86_parse_featurestr() cleanups to b= e the first > * when converting dynamic properties inline custom DEFINE_PROP_FOO direct= ly in > cpu_x86_properties property array. (req: afaerber) > * change "f-" CPUID feature bits prefix to "feat-" (req: afaerber) > * replace F_* macros with a single X86CPU_FEAT() macro and simplify it se= tting > default value to 0, intended for defaults to be set by initfn() > * kvmclock: fix endless loop on compat kvmclock2 append > * converted check_features_against_host() and x86_cpu_list() to use > static properties definition for feature name lookups, removing along t= he way > unused anymore *_feature_name arrays. >=20 > v7-v8: > * split out dynamic properties convertion patch into per property patches > to simplify review > * drop feature bits convertion >=20 > v6-v7: > * convert globals check_cpuid, enforce_cpuid and hyperv_* to fields of > CPUState > * Make PropertyInfo-s static > * maintain legacy kvmclock semantic in cpu_x86_parse_featurestr() > * existing properties code are not moved around, just fixed signatures wh= ere > it's needed and used visitors. >=20 > v5-v6: > * when converting feature names to property names, replace '_' with '-' > * separate patches converting existing dynamic properties into one, were > squashed into one [1/9] and change tested with virt-test(next). > * patches that were touching +-foo features are squashed into one [9/9], > to avoid behavior change between them(f-kvmclock property). > * the rest of conversions were basicaly rebased on top of current qom-cpu= -next > tree, with small corrections >=20 > Igor Mammedov (20): > target-i386: Move hyperv_* static globals to X86CPU > target-i386: convert 'hv_spinlocks' to static property > target-i386: convert 'hv_relaxed' to static property > target-i386: convert 'hv_vapic' to static property > target-i386: convert 'check' and 'enforce' to static properties > target-i386: cleanup 'foo' feature handling' > target-i386: cleanup 'foo=3Dval' feature handling > target-i386: cpu: convert 'level' to static property > target-i386: cpu: convert 'xlevel' to static property > target-i386: cpu: convert 'family' to static property > target-i386: cpu: convert 'model' to static property > target-i386: cpu: convert 'stepping' to static property > target-i386: cpu: convert 'vendor' to static property > target-i386: cpu: convert 'model-id' to static property > target-i386: cpu: convert 'tsc-frequency' to static property > target-i386: set [+-]feature using static properties > qdev: introduce qdev_prop_find_bit() > target-i386: use static properties in check_features_against_host() to > print CPUID feature names > target-i386: use static properties to list CPUID features > target-i386: remove unused *_feature_name arrays >=20 > hw/core/qdev-properties.c | 15 + > include/hw/qdev-properties.h | 13 + > target-i386/Makefile.objs | 2 +- > target-i386/cpu-qom.h | 6 + > target-i386/cpu.c | 705 +++++++++++++++++++++----------------= ------ > target-i386/cpu.h | 4 + > target-i386/hyperv.c | 64 ---- > target-i386/hyperv.h | 45 --- > target-i386/kvm.c | 36 ++- > 9 files changed, 415 insertions(+), 475 deletions(-) > delete mode 100644 target-i386/hyperv.c > delete mode 100644 target-i386/hyperv.h >=20 ping? Hi Igor, Looks fine with me. Best regards, Vadim.