qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH 2/6] hw/gpio/omap_gpio.c: Don't use old_mmio
Date: Sat, 16 Sep 2017 17:46:14 +0100	[thread overview]
Message-ID: <1505580378-9044-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1505580378-9044-1-git-send-email-peter.maydell@linaro.org>

Drop the use of old_mmio in the omap2_gpio memory ops.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/gpio/omap_gpio.c | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c
index 1df394e..17891e2 100644
--- a/hw/gpio/omap_gpio.c
+++ b/hw/gpio/omap_gpio.c
@@ -525,17 +525,23 @@ static void omap2_gpio_module_write(void *opaque, hwaddr addr,
     }
 }
 
-static uint32_t omap2_gpio_module_readp(void *opaque, hwaddr addr)
+static uint64_t omap2_gpio_module_readp(void *opaque, hwaddr addr,
+                                        unsigned size)
 {
     return omap2_gpio_module_read(opaque, addr & ~3) >> ((addr & 3) << 3);
 }
 
 static void omap2_gpio_module_writep(void *opaque, hwaddr addr,
-                uint32_t value)
+                                     uint64_t value, unsigned size)
 {
     uint32_t cur = 0;
     uint32_t mask = 0xffff;
 
+    if (size == 4) {
+        omap2_gpio_module_write(opaque, addr, value);
+        return;
+    }
+
     switch (addr & ~3) {
     case 0x00:	/* GPIO_REVISION */
     case 0x14:	/* GPIO_SYSSTATUS */
@@ -581,18 +587,10 @@ static void omap2_gpio_module_writep(void *opaque, hwaddr addr,
 }
 
 static const MemoryRegionOps omap2_gpio_module_ops = {
-    .old_mmio = {
-        .read = {
-            omap2_gpio_module_readp,
-            omap2_gpio_module_readp,
-            omap2_gpio_module_read,
-        },
-        .write = {
-            omap2_gpio_module_writep,
-            omap2_gpio_module_writep,
-            omap2_gpio_module_write,
-        },
-    },
+    .read = omap2_gpio_module_readp,
+    .write = omap2_gpio_module_writep,
+    .valid.min_access_size = 1,
+    .valid.max_access_size = 4,
     .endianness = DEVICE_NATIVE_ENDIAN,
 };
 
-- 
2.7.4

  parent reply	other threads:[~2017-09-16 16:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-16 16:46 [Qemu-devel] [PATCH 0/6] convert some omap/palm devices from using old_mmio Peter Maydell
2017-09-16 16:46 ` [Qemu-devel] [PATCH 1/6] hw/arm/palm.c: Don't use old_mmio for static_ops Peter Maydell
2017-09-20 20:59   ` Richard Henderson
2017-09-16 16:46 ` Peter Maydell [this message]
2017-09-20 21:00   ` [Qemu-devel] [PATCH 2/6] hw/gpio/omap_gpio.c: Don't use old_mmio Richard Henderson
2017-09-16 16:46 ` [Qemu-devel] [PATCH 3/6] hw/timer/omap_synctimer.c: " Peter Maydell
2017-09-20 21:02   ` Richard Henderson
2017-09-16 16:46 ` [Qemu-devel] [PATCH 4/6] hw/timer/omap_gptimer: " Peter Maydell
2017-09-20 21:02   ` Richard Henderson
2017-09-16 16:46 ` [Qemu-devel] [PATCH 5/6] hw/i2c/omap_i2c.c: " Peter Maydell
2017-09-20 21:03   ` Richard Henderson
2017-09-16 16:46 ` [Qemu-devel] [PATCH 6/6] hw/arm/omap2.c: " Peter Maydell
2017-09-20 21:04   ` Richard Henderson
2017-09-17 13:21 ` [Qemu-devel] [PATCH 0/6] convert some omap/palm devices from using old_mmio Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505580378-9044-3-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).