qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mohammed Gamal <mgamal@redhat.com>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, mst@redhat.com, thuth@redhat.com,
	peterx@redhat.com, pbonzini@redhat.com,
	Mohammed Gamal <mgamal@redhat.com>
Subject: [Qemu-devel] [PATCH v5 0/2] x86_iommu: Fix segfault when starting on non-PCI machines
Date: Tue, 19 Sep 2017 16:51:20 +0200	[thread overview]
Message-ID: <1505832682-27325-1-git-send-email-mgamal@redhat.com> (raw)

Starting qemu with
qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu
leads to a segfault. The code assume PCI bus is present and
tries to access the bus structure without checking.

The patch series moves the error checks from vtd_realize()
and amdvi_realize() to the generic x86_iommu_realize() and
adds a check for PCI bus presence.

v4 --> v5:
   * Squash patch 2/3 from v4 into patch 1/3

Mohammed Gamal (2):
  x86_iommu: Move machine check to x86_iommu_realize()
  x86_iommu: check if machine has PCI bus

 hw/i386/amd_iommu.c   | 13 ++-----------
 hw/i386/intel_iommu.c | 13 ++-----------
 hw/i386/x86-iommu.c   | 13 +++++++++++++
 3 files changed, 17 insertions(+), 22 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2017-09-19 14:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 14:51 Mohammed Gamal [this message]
2017-09-19 14:51 ` [Qemu-devel] [PATCH v5 1/2] x86_iommu: Move machine check to x86_iommu_realize() Mohammed Gamal
2017-09-19 15:00   ` Eduardo Habkost
2017-09-19 14:51 ` [Qemu-devel] [PATCH v5 2/2] x86_iommu: check if machine has PCI bus Mohammed Gamal
2017-09-19 15:01   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505832682-27325-1-git-send-email-mgamal@redhat.com \
    --to=mgamal@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).