From: Gerd Hoffmann <kraxel@redhat.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating problems with pflash
Date: Thu, 21 Sep 2017 08:49:56 +0200 [thread overview]
Message-ID: <1505976596.7353.0.camel@redhat.com> (raw)
In-Reply-To: <20170920145025.19403-1-david@redhat.com>
On Wed, 2017-09-20 at 16:50 +0200, David Hildenbrand wrote:
> pflash toggles mr->romd_mode. So this assert does not always hold.
>
> 1) a device was added with !mr->romd_mode, therefore effectively not
> creating a kvm slot as we want to trap every access (add = false).
> 2) mr->romd_mode was toggled on before remove it. There is now
> actually no slot to remove and the asser is wrong.
>
> So let's just drop the assert.
Works without any obvious bad side effects.
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
next prev parent reply other threads:[~2017-09-21 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 14:50 [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating problems with pflash David Hildenbrand
2017-09-21 6:49 ` Gerd Hoffmann [this message]
2017-09-21 10:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505976596.7353.0.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).