From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: KONRAD Frederic <frederic.konrad@adacore.com>
Subject: [Qemu-devel] [PULL 03/32] memory: avoid a name clash with access macro
Date: Fri, 22 Sep 2017 01:16:11 +0200 [thread overview]
Message-ID: <1506035800-30509-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1506035800-30509-1-git-send-email-pbonzini@redhat.com>
From: KONRAD Frederic <frederic.konrad@adacore.com>
This avoids a name clash with the access macro on windows 64:
make
CHK version_gen.h
CC aarch64-softmmu/memory.o
/home/konrad/qemu/memory.c: In function 'access_with_adjusted_size':
/home/konrad/qemu/memory.c:591:73: error: macro "access" passed 7 arguments, \
but takes just 2
(size - access_size - i) * 8, access_mask, attrs);
^
Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
Message-Id: <1505988260-8483-1-git-send-email-frederic.konrad@adacore.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
memory.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/memory.c b/memory.c
index b9920a6..2b90117 100644
--- a/memory.c
+++ b/memory.c
@@ -560,13 +560,14 @@ static MemTxResult access_with_adjusted_size(hwaddr addr,
unsigned size,
unsigned access_size_min,
unsigned access_size_max,
- MemTxResult (*access)(MemoryRegion *mr,
- hwaddr addr,
- uint64_t *value,
- unsigned size,
- unsigned shift,
- uint64_t mask,
- MemTxAttrs attrs),
+ MemTxResult (*access_fn)
+ (MemoryRegion *mr,
+ hwaddr addr,
+ uint64_t *value,
+ unsigned size,
+ unsigned shift,
+ uint64_t mask,
+ MemTxAttrs attrs),
MemoryRegion *mr,
MemTxAttrs attrs)
{
@@ -587,12 +588,12 @@ static MemTxResult access_with_adjusted_size(hwaddr addr,
access_mask = -1ULL >> (64 - access_size * 8);
if (memory_region_big_endian(mr)) {
for (i = 0; i < size; i += access_size) {
- r |= access(mr, addr + i, value, access_size,
+ r |= access_fn(mr, addr + i, value, access_size,
(size - access_size - i) * 8, access_mask, attrs);
}
} else {
for (i = 0; i < size; i += access_size) {
- r |= access(mr, addr + i, value, access_size, i * 8,
+ r |= access_fn(mr, addr + i, value, access_size, i * 8,
access_mask, attrs);
}
}
--
1.8.3.1
next prev parent reply other threads:[~2017-09-21 23:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 23:16 [Qemu-devel] [PULL 00/32] Misc changes for 2017-09-22 Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 01/32] virtio-serial: add enable_backend callback Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 02/32] kvm: drop wrong assertion creating problems with pflash Paolo Bonzini
2017-09-21 23:16 ` Paolo Bonzini [this message]
2017-09-21 23:16 ` [Qemu-devel] [PULL 04/32] atomic: update documentation Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 05/32] memory: avoid "resurrection" of dead FlatViews Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 06/32] exec: Explicitly export target AS from address_space_translate_internal Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 07/32] memory: Open code FlatView rendering Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 08/32] memory: Move FlatView allocation to a helper Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 09/32] memory: Move AddressSpaceDispatch from AddressSpace to FlatView Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 10/32] memory: Remove AddressSpace pointer from AddressSpaceDispatch Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 11/32] memory: Switch memory from using AddressSpace to FlatView Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 12/32] memory: Cleanup after switching " Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 13/32] memory: Rename mem_begin/mem_commit/mem_add helpers Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 14/32] memory: Store physical root MR in FlatView Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 15/32] memory: Alloc dispatch tree where topology is generared Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 16/32] memory: Move address_space_update_ioeventfds Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 17/32] memory: Share FlatView's and dispatch trees between address spaces Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 18/32] memory: Do not allocate FlatView in address_space_init Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 19/32] memory: Rework "info mtree" to print flat views and dispatch trees Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 20/32] memory: Get rid of address_space_init_shareable Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 21/32] memory: Create FlatView directly Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 22/32] memory: trace FlatView creation and destruction Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 23/32] memory: seek FlatView sharing candidates among children subregions Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 24/32] memory: Share special empty FlatView Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 25/32] scsi, file-posix: add support for persistent reservation management Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 26/32] scsi: build qemu-pr-helper Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 27/32] scsi: add multipath support to qemu-pr-helper Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 28/32] scsi: add persistent reservation manager using qemu-pr-helper Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 29/32] chardev: new qemu_chr_be_update_read_handlers() Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 30/32] chardev: add Chardev.gcontext field Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 31/32] chardev: use per-dev context for io_add_watch_poll Paolo Bonzini
2017-09-21 23:16 ` [Qemu-devel] [PULL 32/32] chardev: remove context in chr_update_read_handler Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506035800-30509-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).