* [Qemu-devel] [PATCH] usb: Fix usb-host build
@ 2017-09-22 7:42 Jan Kiszka
2017-09-25 19:29 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2017-09-22 7:42 UTC (permalink / raw)
To: qemu-devel, Gerd Hoffmann
From: Jan Kiszka <jan.kiszka@siemens.com>
This reverts the incorrect commit 2041649f0b04 (these are
machine-independent objects) and fixes the name of the config var.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/usb/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
index 757e365562..c7f0a52f44 100644
--- a/hw/usb/Makefile.objs
+++ b/hw/usb/Makefile.objs
@@ -38,7 +38,7 @@ endif
common-obj-$(CONFIG_USB_REDIR) += redirect.o quirks.o
# usb pass-through
-ifeq ($(CONFIG_LIBUSB)$(CONFIG_USB),yy)
+ifeq ($(CONFIG_USB_LIBUSB),y)
common-obj-y += host-libusb.o host-legacy.o
else
common-obj-y += host-stub.o
--
2.12.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] usb: Fix usb-host build
2017-09-22 7:42 [Qemu-devel] [PATCH] usb: Fix usb-host build Jan Kiszka
@ 2017-09-25 19:29 ` Peter Maydell
2017-09-26 6:36 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2017-09-25 19:29 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel, Gerd Hoffmann
Gerd, ping? If you provide a reviewed-by or acked-by
I can apply this to master as a buildfix...
thanks
-- PMM
On 22 September 2017 at 08:42, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This reverts the incorrect commit 2041649f0b04 (these are
> machine-independent objects) and fixes the name of the config var.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/usb/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
> index 757e365562..c7f0a52f44 100644
> --- a/hw/usb/Makefile.objs
> +++ b/hw/usb/Makefile.objs
> @@ -38,7 +38,7 @@ endif
> common-obj-$(CONFIG_USB_REDIR) += redirect.o quirks.o
>
> # usb pass-through
> -ifeq ($(CONFIG_LIBUSB)$(CONFIG_USB),yy)
> +ifeq ($(CONFIG_USB_LIBUSB),y)
> common-obj-y += host-libusb.o host-legacy.o
> else
> common-obj-y += host-stub.o
> --
> 2.12.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] usb: Fix usb-host build
2017-09-25 19:29 ` Peter Maydell
@ 2017-09-26 6:36 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2017-09-26 6:36 UTC (permalink / raw)
To: Peter Maydell, Jan Kiszka; +Cc: qemu-devel
On Mon, 2017-09-25 at 20:29 +0100, Peter Maydell wrote:
> Gerd, ping? If you provide a reviewed-by or acked-by
> I can apply this to master as a buildfix...
>
> thanks
> -- PMM
>
> On 22 September 2017 at 08:42, Jan Kiszka <jan.kiszka@siemens.com>
> wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > This reverts the incorrect commit 2041649f0b04 (these are
> > machine-independent objects)
Commit is correct. The objects are machine-independent indeed, but not
all machines need it. s390x (host) doesn't support usb in the first
place, so usb-passthrough is rather pointless. So this drops the
compiled object files from the list for the linker ...
> > and fixes the name of the config var.
That one is needed.
cheers,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-26 6:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 7:42 [Qemu-devel] [PATCH] usb: Fix usb-host build Jan Kiszka
2017-09-25 19:29 ` Peter Maydell
2017-09-26 6:36 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).