* [Qemu-devel] [PATCH] usb: fix libusb config variable name.
@ 2017-09-26 6:38 Gerd Hoffmann
2017-09-26 7:16 ` Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2017-09-26 6:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Jan Kiszka
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Fixes: 4e5ee5b21c84fe3023a64b5cc2e12a52ab0597c1
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
index 9255234c63..0e6d54b21f 100644
--- a/hw/usb/Makefile.objs
+++ b/hw/usb/Makefile.objs
@@ -42,7 +42,7 @@ redirect.o-cflags = $(USB_REDIR_CFLAGS)
redirect.o-libs = $(USB_REDIR_LIBS)
# usb pass-through
-ifeq ($(CONFIG_LIBUSB)$(CONFIG_USB),yy)
+ifeq ($(CONFIG_USB_LIBUSB)$(CONFIG_USB),yy)
common-obj-y += host-libusb.o host-legacy.o
else
common-obj-y += host-stub.o
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] usb: fix libusb config variable name.
2017-09-26 6:38 [Qemu-devel] [PATCH] usb: fix libusb config variable name Gerd Hoffmann
@ 2017-09-26 7:16 ` Jan Kiszka
2017-09-26 7:21 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2017-09-26 7:16 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
On 2017-09-26 08:38, Gerd Hoffmann wrote:
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Fixes: 4e5ee5b21c84fe3023a64b5cc2e12a52ab0597c1
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
> index 9255234c63..0e6d54b21f 100644
> --- a/hw/usb/Makefile.objs
> +++ b/hw/usb/Makefile.objs
> @@ -42,7 +42,7 @@ redirect.o-cflags = $(USB_REDIR_CFLAGS)
> redirect.o-libs = $(USB_REDIR_LIBS)
>
> # usb pass-through
> -ifeq ($(CONFIG_LIBUSB)$(CONFIG_USB),yy)
> +ifeq ($(CONFIG_USB_LIBUSB)$(CONFIG_USB),yy)
> common-obj-y += host-libusb.o host-legacy.o
> else
> common-obj-y += host-stub.o
>
This won't still work, only patch did -> CONFIG_USB isn't set when
building the common objects.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] usb: fix libusb config variable name.
2017-09-26 7:16 ` Jan Kiszka
@ 2017-09-26 7:21 ` Gerd Hoffmann
2017-09-26 8:06 ` Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2017-09-26 7:21 UTC (permalink / raw)
To: Jan Kiszka, qemu-devel
On Tue, 2017-09-26 at 09:16 +0200, Jan Kiszka wrote:
> On 2017-09-26 08:38, Gerd Hoffmann wrote:
> > Cc: Jan Kiszka <jan.kiszka@siemens.com>
> > Fixes: 4e5ee5b21c84fe3023a64b5cc2e12a52ab0597c1
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > hw/usb/Makefile.objs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
> > index 9255234c63..0e6d54b21f 100644
> > --- a/hw/usb/Makefile.objs
> > +++ b/hw/usb/Makefile.objs
> > @@ -42,7 +42,7 @@ redirect.o-cflags = $(USB_REDIR_CFLAGS)
> > redirect.o-libs = $(USB_REDIR_LIBS)
> >
> > # usb pass-through
> > -ifeq ($(CONFIG_LIBUSB)$(CONFIG_USB),yy)
> > +ifeq ($(CONFIG_USB_LIBUSB)$(CONFIG_USB),yy)
> > common-obj-y += host-libusb.o host-legacy.o
> > else
> > common-obj-y += host-stub.o
> >
>
> This won't still work, only patch did -> CONFIG_USB isn't set when
> building the common objects.
I've tested it, and it did work. Also note that there are a bunch of
common-obj-$(CONFIG_USB) += something
lines in hw/usb/Makefile.objs
cheers,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] usb: fix libusb config variable name.
2017-09-26 7:21 ` Gerd Hoffmann
@ 2017-09-26 8:06 ` Jan Kiszka
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2017-09-26 8:06 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
On 2017-09-26 09:21, Gerd Hoffmann wrote:
> On Tue, 2017-09-26 at 09:16 +0200, Jan Kiszka wrote:
>> On 2017-09-26 08:38, Gerd Hoffmann wrote:
>>> Cc: Jan Kiszka <jan.kiszka@siemens.com>
>>> Fixes: 4e5ee5b21c84fe3023a64b5cc2e12a52ab0597c1
>>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>> ---
>>> hw/usb/Makefile.objs | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
>>> index 9255234c63..0e6d54b21f 100644
>>> --- a/hw/usb/Makefile.objs
>>> +++ b/hw/usb/Makefile.objs
>>> @@ -42,7 +42,7 @@ redirect.o-cflags = $(USB_REDIR_CFLAGS)
>>> redirect.o-libs = $(USB_REDIR_LIBS)
>>>
>>> # usb pass-through
>>> -ifeq ($(CONFIG_LIBUSB)$(CONFIG_USB),yy)
>>> +ifeq ($(CONFIG_USB_LIBUSB)$(CONFIG_USB),yy)
>>> common-obj-y += host-libusb.o host-legacy.o
>>> else
>>> common-obj-y += host-stub.o
>>>
>>
>> This won't still work, only patch did -> CONFIG_USB isn't set when
>> building the common objects.
>
> I've tested it, and it did work. Also note that there are a bunch of
>
> common-obj-$(CONFIG_USB) += something
>
> lines in hw/usb/Makefile.objs
>
I swear it didn't while developing the fix, but it does indeed now.
Tested-by: Jan Kiszka <jan.kiszka@siemens.com>
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-26 8:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-26 6:38 [Qemu-devel] [PATCH] usb: fix libusb config variable name Gerd Hoffmann
2017-09-26 7:16 ` Jan Kiszka
2017-09-26 7:21 ` Gerd Hoffmann
2017-09-26 8:06 ` Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).