From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES()
Date: Wed, 4 Oct 2017 12:08:02 +0200 [thread overview]
Message-ID: <1507111682-66171-4-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1507111682-66171-1-git-send-email-imammedo@redhat.com>
DEFINE_TYPES() will help to simplify following routine patterns:
static void foo_register_types(void)
{
type_register_static(&foo1_type_info);
type_register_static(&foo2_type_info);
...
}
type_init(foo_register_types)
or
static void foo_register_types(void)
{
int i;
for (i = 0; i < ARRAY_SIZE(type_infos); i++) {
type_register_static(&type_infos[i]);
}
}
type_init(foo_register_types)
with a single line
DEFINE_TYPES(type_infos)
where types have static definition which could be consolidated in
a single array of TypeInfo structures.
It saves us ~6-10LOC per use case and would help to replace
imperative foo_register_types() there with declarative style of
type registration.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
include/qom/object.h | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index ce25567..a615066 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -79,6 +79,28 @@ typedef struct InterfaceInfo InterfaceInfo;
* #TypeInfo describes information about the type including what it inherits
* from, the instance and class size, and constructor/destructor hooks.
*
+ * Alternatively several static types could be registered using helper macro
+ * DEFINE_TYPES()
+ *
+ * <example>
+ * <programlisting>
+ * static const TypeInfo device_types_info[] = {
+ * {
+ * .name = TYPE_MY_DEVICE_A,
+ * .parent = TYPE_DEVICE,
+ * .instance_size = sizeof(MyDeviceA),
+ * },
+ * {
+ * .name = TYPE_MY_DEVICE_B,
+ * .parent = TYPE_DEVICE,
+ * .instance_size = sizeof(MyDeviceB),
+ * },
+ * };
+ *
+ * DEFINE_TYPES(device_types_info)
+ * </programlisting>
+ * </example>
+ *
* Every type has an #ObjectClass associated with it. #ObjectClass derivatives
* are instantiated dynamically but there is only ever one instance for any
* given type. The #ObjectClass typically holds a table of function pointers
@@ -799,6 +821,20 @@ Type type_register(const TypeInfo *info);
void type_register_static_array(const TypeInfo *infos, int nr_infos);
/**
+ * DEFINE_TYPES:
+ * @type_array: The array containing #TypeInfo structures to register
+ *
+ * @type_array should be static constant that exists for the life time
+ * that the type is registered.
+ */
+#define DEFINE_TYPES(type_array) \
+static void do_qemu_init_ ## type_array(void) \
+{ \
+ type_register_static_array(type_array, ARRAY_SIZE(type_array)); \
+} \
+type_init(do_qemu_init_ ## type_array)
+
+/**
* object_class_dynamic_cast_assert:
* @klass: The #ObjectClass to attempt to cast.
* @typename: The QOM typename of the class to cast to.
--
2.7.4
next prev parent reply other threads:[~2017-10-04 10:08 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 9:07 [Qemu-devel] [PATCH 00/38] generalize parsing of cpu_model (part 2) Igor Mammedov
2017-10-02 9:07 ` [Qemu-devel] [PATCH 01/38] qom: add helper type_init_from_array() Igor Mammedov
2017-10-02 14:15 ` Philippe Mathieu-Daudé
2017-10-02 19:24 ` Eduardo Habkost
2017-10-03 12:13 ` Igor Mammedov
2017-10-03 12:14 ` [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S]() Igor Mammedov
2017-10-03 13:29 ` Philippe Mathieu-Daudé
2017-10-03 15:38 ` Igor Mammedov
2017-10-03 14:25 ` Eduardo Habkost
2017-10-03 15:01 ` Igor Mammedov
2017-10-03 15:37 ` Eduardo Habkost
2017-10-03 16:37 ` Igor Mammedov
2017-10-03 18:24 ` Eduardo Habkost
2017-10-03 15:44 ` Peter Maydell
2017-10-03 16:41 ` Igor Mammedov
2017-10-04 10:07 ` [Qemu-devel] [PATCH v2 0/3] add DEFINE_TYPES() helper to simplify batch type registration Igor Mammedov
2017-10-04 10:08 ` [Qemu-devel] [PATCH v2 1/3] qom: update doc comment for type_register[_static]() Igor Mammedov
2017-10-04 20:58 ` Eduardo Habkost
2017-10-04 10:08 ` [Qemu-devel] [PATCH v2 2/3] qom: introduce type_register_static_array() Igor Mammedov
2017-10-04 21:03 ` Eduardo Habkost
2017-10-05 12:36 ` Philippe Mathieu-Daudé
2017-10-04 10:08 ` Igor Mammedov [this message]
2017-10-04 21:04 ` [Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES() Eduardo Habkost
2017-10-05 8:10 ` Igor Mammedov
2017-10-05 12:36 ` Philippe Mathieu-Daudé
2017-10-02 9:07 ` [Qemu-devel] [PATCH 02/38] alpha: cleanup cpu type name composition Igor Mammedov
2017-10-02 12:01 ` Richard Henderson
2017-10-02 14:46 ` Philippe Mathieu-Daudé
2017-10-02 9:07 ` [Qemu-devel] [PATCH 03/38] alpha: use generic cpu_model parsing Igor Mammedov
2017-10-02 12:01 ` Richard Henderson
2017-10-02 14:46 ` Philippe Mathieu-Daudé
2017-10-02 9:07 ` [Qemu-devel] [PATCH 04/38] cris: cleanup cpu type name composition Igor Mammedov
2017-10-02 14:51 ` Philippe Mathieu-Daudé
2017-10-02 15:03 ` Igor Mammedov
2017-10-02 9:07 ` [Qemu-devel] [PATCH 05/38] cris: use generic cpu_model parsing Igor Mammedov
2017-10-02 14:52 ` Philippe Mathieu-Daudé
2017-10-02 9:07 ` [Qemu-devel] [PATCH 06/38] lm32: cleanup cpu type name composition Igor Mammedov
2017-10-02 20:28 ` Philippe Mathieu-Daudé
2017-10-03 13:00 ` Michael Walle
2017-10-02 9:07 ` [Qemu-devel] [PATCH 07/38] lm32: milkymist: use generic cpu_model parsing Igor Mammedov
2017-10-02 20:28 ` Philippe Mathieu-Daudé
2017-10-03 13:01 ` Michael Walle
2017-10-02 9:07 ` [Qemu-devel] [PATCH 08/38] lm32: lm32_boards: " Igor Mammedov
2017-10-02 20:29 ` Philippe Mathieu-Daudé
2017-10-03 13:01 ` Michael Walle
2017-10-02 9:07 ` [Qemu-devel] [PATCH 09/38] m68k: cleanup cpu type name composition Igor Mammedov
2017-10-03 13:31 ` Philippe Mathieu-Daudé
2017-10-03 14:50 ` Laurent Vivier
2017-10-02 9:07 ` [Qemu-devel] [PATCH 10/38] m68k: an5206: use generic cpu_model parsing Igor Mammedov
2017-10-03 9:13 ` Thomas Huth
2017-10-03 13:31 ` Philippe Mathieu-Daudé
2017-10-03 14:51 ` Laurent Vivier
2017-10-02 9:07 ` [Qemu-devel] [PATCH 11/38] m68k: mcf5208: " Igor Mammedov
2017-10-03 9:28 ` Thomas Huth
2017-10-03 13:32 ` Philippe Mathieu-Daudé
2017-10-03 14:52 ` Laurent Vivier
2017-10-02 9:07 ` [Qemu-devel] [PATCH 12/38] moxie: fix qemu-system-moxie failing to start with CLI "-cpu MoxieLite" Igor Mammedov
2017-10-03 13:37 ` Philippe Mathieu-Daudé
2017-10-02 9:07 ` [Qemu-devel] [PATCH 13/38] moxie: cleanup cpu type name composition Igor Mammedov
2017-10-02 14:54 ` Philippe Mathieu-Daudé
2017-10-02 9:07 ` [Qemu-devel] [PATCH 14/38] moxie: use generic cpu_model parsing Igor Mammedov
2017-10-02 14:13 ` Philippe Mathieu-Daudé
2017-10-02 9:07 ` [Qemu-devel] [PATCH 15/38] openrisc: cleanup cpu type name composition Igor Mammedov
2017-10-02 20:19 ` Philippe Mathieu-Daudé
2017-10-02 9:07 ` [Qemu-devel] [PATCH 16/38] openrisc: use generic cpu_model parsing Igor Mammedov
2017-10-02 20:20 ` Philippe Mathieu-Daudé
2017-10-02 9:07 ` [Qemu-devel] [PATCH 17/38] sh4: r2d: " Igor Mammedov
2017-10-05 12:37 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 18/38] sh4: shix: " Igor Mammedov
2017-10-05 12:48 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 19/38] sh4: cleanup cpu type name composition Igor Mammedov
2017-10-05 12:39 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 20/38] sh4: simplify superh_cpu_class_by_name() Igor Mammedov
2017-10-05 12:56 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 21/38] sh4: remove SuperHCPUClass::name field Igor Mammedov
2017-10-05 12:42 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 22/38] xtensa: cleanup cpu type name composition Igor Mammedov
2017-10-02 20:35 ` Philippe Mathieu-Daudé
2017-10-03 10:37 ` Igor Mammedov
2017-10-03 13:33 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 23/38] xtensa: sim: use generic cpu_model parsing Igor Mammedov
2017-10-03 13:34 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 24/38] xtensa: lx60/lx200/ml605/kc705: " Igor Mammedov
2017-10-03 13:34 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 25/38] unicore32: cleanup cpu type name composition Igor Mammedov
2017-10-02 20:18 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 26/38] unicore32: use generic cpu_model parsing Igor Mammedov
2017-10-02 20:18 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 27/38] tricore: cleanup cpu type name composition Igor Mammedov
2017-10-02 20:30 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 28/38] tricore: use generic cpu_model parsing Igor Mammedov
2017-10-02 20:30 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 29/38] sparc: cleanup cpu type name composition Igor Mammedov
2017-10-02 15:01 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 30/38] sparc: sun4u/sun4v/niagara: use generic cpu_model parsing Igor Mammedov
2017-10-02 20:16 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 31/38] sparc: sparc: " Igor Mammedov
2017-10-02 15:02 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 32/38] sparc: leon3: " Igor Mammedov
2017-10-02 15:54 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 33/38] mips: use object_new() instead of gnew()+object_initialize() Igor Mammedov
2017-10-02 14:09 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 34/38] mips: malta/boston: replace cpu_model with cpu_type Igor Mammedov
2017-10-02 14:10 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 35/38] mips: fulong2e: " Igor Mammedov
2017-10-02 14:11 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 36/38] mips: Magnum/Acer Pica 61: " Igor Mammedov
2017-10-02 14:11 ` Philippe Mathieu-Daudé
2017-10-03 4:59 ` Hervé Poussineau
2017-10-02 9:08 ` [Qemu-devel] [PATCH 37/38] mips: mipssim: " Igor Mammedov
2017-10-02 14:12 ` Philippe Mathieu-Daudé
2017-10-02 9:08 ` [Qemu-devel] [PATCH 38/38] mips: r4k: " Igor Mammedov
2017-10-02 14:12 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507111682-66171-4-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).