From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzk76-0000N7-0n for qemu-devel@nongnu.org; Wed, 04 Oct 2017 09:53:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzk72-0006uw-4H for qemu-devel@nongnu.org; Wed, 04 Oct 2017 09:53:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34382) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzk71-0006ud-U7 for qemu-devel@nongnu.org; Wed, 04 Oct 2017 09:53:24 -0400 From: Thomas Huth Date: Wed, 4 Oct 2017 15:53:19 +0200 Message-Id: <1507125199-22562-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH] hw/s390x/sclp: Mark the sclp device with user_creatable = false List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Cornelia Huck , Christian Borntraeger Cc: Claudio Imbrenda , Dong Jia Shi , Eric Farman , Farhan Ali , Fei Li , Halil Pasic , Janosch Frank , Jason J Herne , Jing Liu , Pierre Morel , QingFeng Hao , Xiao Feng Ren , Yang Chen , Yi Min Zhao The "sclp" device is just an internal device that can not be instantiated by the users. If they try to use it, they only get a simple error message: $ qemu-system-s390x -nographic -device sclp qemu-system-s390x: Option '-device s390-sclp-event-facility' cannot be handled by this machine Since sclp_init() tries to create a TYPE_SCLP_EVENT_FACILITY which is a non-pluggable sysbus device, there is really no way that the "sclp" device can be used by the user, so let's set the user_creatable = false accordingly. Signed-off-by: Thomas Huth --- hw/s390x/sclp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 30aefbf..9be0cb8 100644 --- a/hw/s390x/sclp.c +++ b/hw/s390x/sclp.c @@ -606,6 +606,11 @@ static void sclp_class_init(ObjectClass *oc, void *data) dc->realize = sclp_realize; dc->hotpluggable = false; set_bit(DEVICE_CATEGORY_MISC, dc->categories); + /* + * Reason: Creates TYPE_SCLP_EVENT_FACILITY in sclp_init + * which is a non-pluggable sysbus device + */ + dc->user_creatable = false; sc->read_SCP_info = read_SCP_info; sc->read_storage_element0_info = read_storage_element0_info; -- 1.8.3.1