From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PATCH v2 01/40] qom: update doc comment for type_register[_static]()
Date: Thu, 5 Oct 2017 15:50:35 +0200 [thread overview]
Message-ID: <1507211474-188400-2-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1507211474-188400-1-git-send-email-imammedo@redhat.com>
type_register()/type_register_static() functions in current impl.
can't fail returning 0, also none of the users check for error
so update doc comment to reflect current behaviour.
Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
include/qom/object.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index f3e5cff..76a5e3a 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -773,7 +773,7 @@ const char *object_get_typename(const Object *obj);
* @info and all of the strings it points to should exist for the life time
* that the type is registered.
*
- * Returns: 0 on failure, the new #Type on success.
+ * Returns: the new #Type.
*/
Type type_register_static(const TypeInfo *info);
@@ -784,7 +784,7 @@ Type type_register_static(const TypeInfo *info);
* Unlike type_register_static(), this call does not require @info or its
* string members to continue to exist after the call returns.
*
- * Returns: 0 on failure, the new #Type on success.
+ * Returns: the new #Type.
*/
Type type_register(const TypeInfo *info);
--
2.7.4
next prev parent reply other threads:[~2017-10-05 13:51 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 13:50 [Qemu-devel] [PATCH v2 00/40] generalize parsing of cpu_model (part 2) Igor Mammedov
2017-10-05 13:50 ` Igor Mammedov [this message]
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 02/40] qom: introduce type_register_static_array() Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 03/40] qom: add helper macro DEFINE_TYPES() Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 04/40] alpha: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 05/40] alpha: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 06/40] cris: cleanup cpu type name composition Igor Mammedov
2017-10-05 15:17 ` Philippe Mathieu-Daudé
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 07/40] cris: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 08/40] lm32: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 09/40] lm32: milkymist: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 10/40] lm32: lm32_boards: " Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 11/40] m68k: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 12/40] m68k: an5206: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 13/40] m68k: mcf5208: " Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 14/40] moxie: fix qemu-system-moxie failing to start with CLI "-cpu MoxieLite" Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 15/40] moxie: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 16/40] moxie: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 17/40] openrisc: cleanup cpu type name composition Igor Mammedov
2017-10-07 0:13 ` Stafford Horne
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 18/40] openrisc: use generic cpu_model parsing Igor Mammedov
2017-10-07 0:13 ` Stafford Horne
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 19/40] sh4: r2d: " Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 20/40] sh4: shix: " Igor Mammedov
2017-10-05 15:15 ` Philippe Mathieu-Daudé
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 21/40] sh4: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 22/40] sh4: simplify superh_cpu_class_by_name() Igor Mammedov
2017-10-05 15:16 ` Philippe Mathieu-Daudé
2017-10-18 8:30 ` [Qemu-devel] [PATCH 22/40] fixup: " Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 23/40] sh4: remove SuperHCPUClass::name field Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 24/40] xtensa: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 25/40] xtensa: sim: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 26/40] xtensa: lx60/lx200/ml605/kc705: " Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 27/40] unicore32: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 28/40] unicore32: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 29/40] tricore: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 30/40] tricore: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 31/40] sparc: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 32/40] sparc: sun4u/sun4v/niagara: use generic cpu_model parsing Igor Mammedov
2017-10-05 14:27 ` Artyom Tarasenko
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 33/40] sparc: sparc: " Igor Mammedov
2017-10-05 14:27 ` Artyom Tarasenko
2017-10-05 17:25 ` Mark Cave-Ayland
2017-10-06 7:37 ` Igor Mammedov
2017-10-06 11:17 ` Mark Cave-Ayland
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 34/40] sparc: leon3: " Igor Mammedov
2017-10-05 14:28 ` Artyom Tarasenko
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 35/40] mips: use object_new() instead of gnew()+object_initialize() Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 36/40] mips: malta/boston: replace cpu_model with cpu_type Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 37/40] mips: fulong2e: " Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 38/40] mips: Magnum/Acer Pica 61: " Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 39/40] mips: mipssim: " Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 40/40] mips: r4k: " Igor Mammedov
2017-10-12 16:27 ` [Qemu-devel] [PATCH v2 00/40] generalize parsing of cpu_model (part 2) Igor Mammedov
2017-10-13 19:13 ` Eduardo Habkost
2017-10-16 8:03 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507211474-188400-2-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).