qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v2 20/40] sh4: shix: use generic cpu_model parsing
Date: Thu,  5 Oct 2017 15:50:54 +0200	[thread overview]
Message-ID: <1507211474-188400-21-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1507211474-188400-1-git-send-email-imammedo@redhat.com>

default cpu model 'any' resolves to type TYPE_SH7750R_CPU
in superh_cpu_class_by_name(), so use it directly.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2:
  - Explain in commit message why default cpu model 'any' is
    replaced by TYPE_SH7750R_CPU (Philippe Mathieu-Daudé)

CC: Magnus Damm <magnus.damm@gmail.com>
CC: Aurelien Jarno <aurelien@aurel32.net>
---
 hw/sh4/shix.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
index 50ee36a..4add230 100644
--- a/hw/sh4/shix.c
+++ b/hw/sh4/shix.c
@@ -45,7 +45,6 @@
 
 static void shix_init(MachineState *machine)
 {
-    const char *cpu_model = machine->cpu_model;
     int ret;
     SuperHCPU *cpu;
     struct SH7750State *s;
@@ -53,10 +52,7 @@ static void shix_init(MachineState *machine)
     MemoryRegion *rom = g_new(MemoryRegion, 1);
     MemoryRegion *sdram = g_new(MemoryRegion, 2);
     
-    if (!cpu_model)
-        cpu_model = "any";
-
-    cpu = SUPERH_CPU(cpu_generic_init(TYPE_SUPERH_CPU, cpu_model));
+    cpu = SUPERH_CPU(cpu_create(machine->cpu_type));
 
     /* Allocate memory space */
     memory_region_init_ram(rom, NULL, "shix.rom", 0x4000, &error_fatal);
@@ -89,6 +85,7 @@ static void shix_machine_init(MachineClass *mc)
     mc->desc = "shix card";
     mc->init = shix_init;
     mc->is_default = 1;
+    mc->default_cpu_type = TYPE_SH7750R_CPU;
 }
 
 DEFINE_MACHINE("shix", shix_machine_init)
-- 
2.7.4

  parent reply	other threads:[~2017-10-05 13:51 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 13:50 [Qemu-devel] [PATCH v2 00/40] generalize parsing of cpu_model (part 2) Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 01/40] qom: update doc comment for type_register[_static]() Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 02/40] qom: introduce type_register_static_array() Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 03/40] qom: add helper macro DEFINE_TYPES() Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 04/40] alpha: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 05/40] alpha: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 06/40] cris: cleanup cpu type name composition Igor Mammedov
2017-10-05 15:17   ` Philippe Mathieu-Daudé
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 07/40] cris: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 08/40] lm32: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 09/40] lm32: milkymist: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 10/40] lm32: lm32_boards: " Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 11/40] m68k: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 12/40] m68k: an5206: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 13/40] m68k: mcf5208: " Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 14/40] moxie: fix qemu-system-moxie failing to start with CLI "-cpu MoxieLite" Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 15/40] moxie: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 16/40] moxie: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 17/40] openrisc: cleanup cpu type name composition Igor Mammedov
2017-10-07  0:13   ` Stafford Horne
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 18/40] openrisc: use generic cpu_model parsing Igor Mammedov
2017-10-07  0:13   ` Stafford Horne
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 19/40] sh4: r2d: " Igor Mammedov
2017-10-05 13:50 ` Igor Mammedov [this message]
2017-10-05 15:15   ` [Qemu-devel] [PATCH v2 20/40] sh4: shix: " Philippe Mathieu-Daudé
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 21/40] sh4: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 22/40] sh4: simplify superh_cpu_class_by_name() Igor Mammedov
2017-10-05 15:16   ` Philippe Mathieu-Daudé
2017-10-18  8:30   ` [Qemu-devel] [PATCH 22/40] fixup: " Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 23/40] sh4: remove SuperHCPUClass::name field Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 24/40] xtensa: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:50 ` [Qemu-devel] [PATCH v2 25/40] xtensa: sim: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 26/40] xtensa: lx60/lx200/ml605/kc705: " Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 27/40] unicore32: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 28/40] unicore32: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 29/40] tricore: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 30/40] tricore: use generic cpu_model parsing Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 31/40] sparc: cleanup cpu type name composition Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 32/40] sparc: sun4u/sun4v/niagara: use generic cpu_model parsing Igor Mammedov
2017-10-05 14:27   ` Artyom Tarasenko
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 33/40] sparc: sparc: " Igor Mammedov
2017-10-05 14:27   ` Artyom Tarasenko
2017-10-05 17:25   ` Mark Cave-Ayland
2017-10-06  7:37     ` Igor Mammedov
2017-10-06 11:17       ` Mark Cave-Ayland
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 34/40] sparc: leon3: " Igor Mammedov
2017-10-05 14:28   ` Artyom Tarasenko
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 35/40] mips: use object_new() instead of gnew()+object_initialize() Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 36/40] mips: malta/boston: replace cpu_model with cpu_type Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 37/40] mips: fulong2e: " Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 38/40] mips: Magnum/Acer Pica 61: " Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 39/40] mips: mipssim: " Igor Mammedov
2017-10-05 13:51 ` [Qemu-devel] [PATCH v2 40/40] mips: r4k: " Igor Mammedov
2017-10-12 16:27 ` [Qemu-devel] [PATCH v2 00/40] generalize parsing of cpu_model (part 2) Igor Mammedov
2017-10-13 19:13   ` Eduardo Habkost
2017-10-16  8:03     ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507211474-188400-21-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=f4bug@amsat.org \
    --cc=magnus.damm@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).