Re: [Qemu-devel] [PATCH] pc: make sure that plugged CPUs are of the same type

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1507638879-200718-1-git-send-email-imammedo@redhat.com
Subject: [Qemu-devel] [PATCH] pc: make sure that plugged CPUs are of the same type

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20171010102418.13487-1-anthony.perard@citrix.com -> patchew/20171010102418.13487-1-anthony.perard@citrix.com
Switched to a new branch 'test'
606d6b2956 pc: make sure that plugged CPUs are of the same type

=== OUTPUT BEGIN ===
Checking PATCH 1/1: pc: make sure that plugged CPUs are of the same type...
ERROR: space required before the open parenthesis '('
#33: FILE: hw/i386/pc.c:1882:
+    if(!object_dynamic_cast(OBJECT(cpu), ms->cpu_type)) {

total: 1 errors, 0 warnings, 15 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org