From: Andrea Bolognani <abologna@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
lvivier@redhat.com, groug@kaod.org, clg@kaod.org
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: Correct RAM size calculation for HPT resizing
Date: Tue, 10 Oct 2017 17:10:27 +0200 [thread overview]
Message-ID: <1507648227.3683.24.camel@redhat.com> (raw)
In-Reply-To: <20171010132159.15787-1-david@gibson.dropbear.id.au>
On Wed, 2017-10-11 at 00:21 +1100, David Gibson wrote:
> In order to prevent the guest from forcing the allocation of large amounts
> of qemu memory (or host kernel memory, in the case of KVM HV), we limit
> the size of Hashed Page Table (HPT) it is allowed to allocated, based on
> its RAM size.
>
> However, the current calculation is not correct: it only adds up the size
> of plugged memory, ignoring the base memory size. This patch corrects it.
>
> While we're there, use get_plugged_memory_size() instead of directly
> calling pc_existing_dimms_capacity(). The only difference is that it
> will abort on failure, which is right: a failure here indicates something
> wrong within qemu.
Does this change invalidate in any way the calculation performed
by libvirt to figure out the memory locking limit for guests?
--
Andrea Bolognani / Red Hat / Virtualization
next prev parent reply other threads:[~2017-10-10 15:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 13:21 [Qemu-devel] [PATCH] spapr: Correct RAM size calculation for HPT resizing David Gibson
2017-10-10 13:59 ` Laurent Vivier
2017-10-10 14:44 ` Greg Kurz
2017-10-10 15:21 ` Laurent Vivier
2017-10-11 0:04 ` David Gibson
2017-10-10 15:10 ` Andrea Bolognani [this message]
2017-10-10 23:20 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2017-10-10 15:16 ` [Qemu-devel] " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507648227.3683.24.camel@redhat.com \
--to=abologna@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).