* [Qemu-devel] [PATCH] nvic: Add missing 'break'
@ 2017-10-11 17:24 Peter Maydell
2017-10-11 19:31 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-10-12 15:11 ` [Qemu-devel] " Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2017-10-11 17:24 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: patches, Richard Henderson
Coverity points out that we forgot the 'break' for
the SAU_CTRL write case (CID1381683). This has
no actual visible consequences because it happens
that the following case is effectively a no-op.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/intc/armv7m_nvic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
index 201e90f..be46639 100644
--- a/hw/intc/armv7m_nvic.c
+++ b/hw/intc/armv7m_nvic.c
@@ -1447,6 +1447,7 @@ static void nvic_writel(NVICState *s, uint32_t offset, uint32_t value,
return;
}
cpu->env.sau.ctrl = value & 3;
+ break;
case 0xdd4: /* SAU_TYPE */
if (!arm_feature(&cpu->env, ARM_FEATURE_V8)) {
goto bad_offset;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-arm] [PATCH] nvic: Add missing 'break'
2017-10-11 17:24 [Qemu-devel] [PATCH] nvic: Add missing 'break' Peter Maydell
@ 2017-10-11 19:31 ` Philippe Mathieu-Daudé
2017-10-12 15:11 ` [Qemu-devel] " Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-10-11 19:31 UTC (permalink / raw)
To: Peter Maydell, qemu-arm, qemu-devel; +Cc: Richard Henderson, patches
On 10/11/2017 02:24 PM, Peter Maydell wrote:
> Coverity points out that we forgot the 'break' for
> the SAU_CTRL write case (CID1381683). This has
> no actual visible consequences because it happens
> that the following case is effectively a no-op.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/intc/armv7m_nvic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
> index 201e90f..be46639 100644
> --- a/hw/intc/armv7m_nvic.c
> +++ b/hw/intc/armv7m_nvic.c
> @@ -1447,6 +1447,7 @@ static void nvic_writel(NVICState *s, uint32_t offset, uint32_t value,
> return;
> }
> cpu->env.sau.ctrl = value & 3;
> + break;
> case 0xdd4: /* SAU_TYPE */
> if (!arm_feature(&cpu->env, ARM_FEATURE_V8)) {
> goto bad_offset;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] nvic: Add missing 'break'
2017-10-11 17:24 [Qemu-devel] [PATCH] nvic: Add missing 'break' Peter Maydell
2017-10-11 19:31 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
@ 2017-10-12 15:11 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2017-10-12 15:11 UTC (permalink / raw)
To: Peter Maydell, qemu-arm, qemu-devel; +Cc: patches
On 10/11/2017 10:24 AM, Peter Maydell wrote:
> Coverity points out that we forgot the 'break' for
> the SAU_CTRL write case (CID1381683). This has
> no actual visible consequences because it happens
> that the following case is effectively a no-op.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/intc/armv7m_nvic.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-12 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-11 17:24 [Qemu-devel] [PATCH] nvic: Add missing 'break' Peter Maydell
2017-10-11 19:31 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-10-12 15:11 ` [Qemu-devel] " Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).