* [Qemu-devel] [PATCH] include/hw/or-irq.h: Drop unused in_irqs field
@ 2017-10-12 13:17 Peter Maydell
2017-10-12 16:36 ` Alistair Francis
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2017-10-12 13:17 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: patches, Alistair Francis
The struct OrIRQState has an unused member field in_irqs.
This is a legacy of earlier versions of the patch; the
code that used it was dropped from the final version of
the code that went into master, but we forgot to delete
the no-longer-used struct field. Do so now.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
include/hw/or-irq.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/hw/or-irq.h b/include/hw/or-irq.h
index d400a81..fd900fc 100644
--- a/include/hw/or-irq.h
+++ b/include/hw/or-irq.h
@@ -38,7 +38,6 @@ struct OrIRQState {
DeviceState parent_obj;
qemu_irq out_irq;
- qemu_irq *in_irqs;
bool levels[MAX_OR_LINES];
uint16_t num_lines;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] include/hw/or-irq.h: Drop unused in_irqs field
2017-10-12 13:17 [Qemu-devel] [PATCH] include/hw/or-irq.h: Drop unused in_irqs field Peter Maydell
@ 2017-10-12 16:36 ` Alistair Francis
0 siblings, 0 replies; 2+ messages in thread
From: Alistair Francis @ 2017-10-12 16:36 UTC (permalink / raw)
To: Peter Maydell
Cc: qemu-devel@nongnu.org Developers, QEMU Trivial, Alistair Francis,
Patch Tracking
On Thu, Oct 12, 2017 at 6:17 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> The struct OrIRQState has an unused member field in_irqs.
> This is a legacy of earlier versions of the patch; the
> code that used it was dropped from the final version of
> the code that went into master, but we forgot to delete
> the no-longer-used struct field. Do so now.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Good catch.
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Thanks,
Alistair
> ---
> include/hw/or-irq.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/or-irq.h b/include/hw/or-irq.h
> index d400a81..fd900fc 100644
> --- a/include/hw/or-irq.h
> +++ b/include/hw/or-irq.h
> @@ -38,7 +38,6 @@ struct OrIRQState {
> DeviceState parent_obj;
>
> qemu_irq out_irq;
> - qemu_irq *in_irqs;
> bool levels[MAX_OR_LINES];
> uint16_t num_lines;
> };
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-12 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 13:17 [Qemu-devel] [PATCH] include/hw/or-irq.h: Drop unused in_irqs field Peter Maydell
2017-10-12 16:36 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).